Summary: | xine-lib-1-rc8 emerge fails djb_demux_aiff patch | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Josh Joyce <j_joyce2001> |
Component: | New packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | charlie |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | The "new" patch |
Description
Josh Joyce
2004-12-22 21:35:32 UTC
Have the same problem but in xine-lib-1_rc8-r1. I copied the patch from files/djb_demux_aiff.patch to files/xine-lib-1_rc8-djb_demux_aiff.patch and removed the top 5 lines and cut out the first chunk (as it does nothing?). Anyway, the patch now reads: [snip] --- src/demuxers/demux_aiff.orig 2004/06/13 21:28:52 1.39 +++ src/demuxers/demux_aiff.c 2004/12/15 21:03:02 1.40 @@ -120,6 +120,12 @@ } chunk_type = BE_32(&preamble[0]); chunk_size = BE_32(&preamble[4]); + + if (chunk_size > sizeof(buffer) / sizeof(buffer[0])) { + /* the chunk is too large to fit in the buffer -> this cannot be an aiff chunk */ + this->status = DEMUX_FINISHED; + return 0; + } if (chunk_type == COMM_TAG) { if (this->input->read(this->input, buffer, chunk_size) != [/snip] And change the ebuild, in this case the rc8, in my case rc8-r1 to read epatch ${FILESDIR}/xine-lib-1_rc8-djb_demux_aiff.patch This made the patch insert, but configure later complains: 'configure: error: conditional "HAVE_XV" was never defined. Usually this means the macro was only invoked conditionally.' but I think thats another bug# ;) So edit your ebuild and add the patch to your files-dir and try again. Thanks! / Have the same problem but in xine-lib-1_rc8-r1. I copied the patch from files/djb_demux_aiff.patch to files/xine-lib-1_rc8-djb_demux_aiff.patch and removed the top 5 lines and cut out the first chunk (as it does nothing?). Anyway, the patch now reads: [snip] --- src/demuxers/demux_aiff.orig 2004/06/13 21:28:52 1.39 +++ src/demuxers/demux_aiff.c 2004/12/15 21:03:02 1.40 @@ -120,6 +120,12 @@ } chunk_type = BE_32(&preamble[0]); chunk_size = BE_32(&preamble[4]); + + if (chunk_size > sizeof(buffer) / sizeof(buffer[0])) { + /* the chunk is too large to fit in the buffer -> this cannot be an aiff chunk */ + this->status = DEMUX_FINISHED; + return 0; + } if (chunk_type == COMM_TAG) { if (this->input->read(this->input, buffer, chunk_size) != [/snip] And change the ebuild, in this case the rc8, in my case rc8-r1 to read epatch ${FILESDIR}/xine-lib-1_rc8-djb_demux_aiff.patch This made the patch insert, but configure later complains: 'configure: error: conditional "HAVE_XV" was never defined. Usually this means the macro was only invoked conditionally.' but I think thats another bug# ;) So edit your ebuild and add the patch to your files-dir and try again. Thanks! /©harlie Created attachment 46694 [details, diff]
The "new" patch
To put in files-dir.
*** Bug 75410 has been marked as a duplicate of this bug. *** I'm marking this as fixed. After an emerge sync, this issue disappeared. closing |