Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 753923

Summary: lxde-base/lxpanel depends on gdk-pixbuf[X]
Product: Gentoo Linux Reporter: Matt Turner <mattst88>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: normal CC: ionen
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://github.com/lxde/lxpanel/pull/20
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 534330    
Attachments: lxpanel-remove-gdk-pixbuf-xlib.patch

Description Matt Turner gentoo-dev 2020-11-10 19:18:02 UTC
> plugin.c:32:10: fatal error: gdk-pixbuf-xlib/gdk-pixbuf-xlib.h: No such file or directory
>    32 | #include <gdk-pixbuf-xlib/gdk-pixbuf-xlib.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.

gdk-pixbuf-xlib was removed in v2.42.0.
Comment 1 Ionen Wolkens gentoo-dev 2020-11-10 19:37:29 UTC
Created attachment 670799 [details, diff]
lxpanel-remove-gdk-pixbuf-xlib.patch

Given based on fbpanel, seems same deal as bug #753908

Likewise, can remove the include lines and there's no problem.

Unlike fbpanel it has active upstream so could be taken there, but patch applies to every versions currently in tree if need be.
Comment 2 Matt Turner gentoo-dev 2020-11-11 19:17:28 UTC
Nice, thanks. Would you mind making a pull request upstream and linking it here?
Comment 3 Ionen Wolkens gentoo-dev 2020-11-11 20:25:14 UTC
(In reply to Matt Turner from comment #2)
> Nice, thanks. Would you mind making a pull request upstream and linking it
> here?
I'd appreciate if someone more familiar with lxpanel and its upstream took care of this (I don't actually use it myself).
Comment 4 Matt Turner gentoo-dev 2020-11-11 20:36:08 UTC
No problem. I'm not familiar with LXDE either, but since it's maintainerless in Gentoo I went ahead and created a pull request.
Comment 5 Larry the Git Cow gentoo-dev 2020-11-11 20:43:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f074ed72974ef67106b7aa7b720d2aa41dae98cb

commit f074ed72974ef67106b7aa7b720d2aa41dae98cb
Author:     Ionen Wolkens <sudinave@gmail.com>
AuthorDate: 2020-11-11 20:42:33 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-11-11 20:43:22 +0000

    lxde-base/lxpanel: Remove unnecessary gdk-pixbuf-xlib.h includes
    
    Closes: https://bugs.gentoo.org/753923
    Signed-off-by: Ionen Wolkens <sudinave@gmail.com>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 .../files/lxpanel-remove-gdk-pixbuf-xlib.patch     | 26 ++++++++++++++++++++++
 lxde-base/lxpanel/lxpanel-0.10.0.ebuild            |  4 ++++
 2 files changed, 30 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2020-11-11 20:45:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=00ad8f2a4637aafabc661046a9c1712ea361a32d

commit 00ad8f2a4637aafabc661046a9c1712ea361a32d
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2020-11-11 20:44:15 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-11-11 20:44:59 +0000

    lxde-base/lxpanel: Remove USE=X gdk-pixbuf dependency
    
    This was my fault (again).
    
    Bug: https://bugs.gentoo.org/753923
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 lxde-base/lxpanel/{lxpanel-0.10.0.ebuild => lxpanel-0.10.0-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)