Bug 753854 – net-misc/ntpsec-1.1.9: MAKEOPTS not respected

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description crabbed halo ablution 2020-11-10 13:55:11 UTC]

ntpsec unsets MAKEOPTS. I have repeatedly built ntpsec without this in tmpfs on a 12-core cpu and have not been able to produce a parallel-build failure.
git blame fingers this commit in the -9999 ebuild as the place where it was first introduced:
https://github.com/gentoo/gentoo/commit/8b1d82cd97939eca1f801304c9a516533b1b9a9f

Maybe it was a transient failure fixed in later git versions?

Difference in build times on Ryzen 9 3900X:
unset MAKEOPTS
real	1m54,226s
user	1m40,297s
sys	0m20,287s
MAKEOPTS=-j24
real	0m29,581s
user	2m27,881s
sys	0m29,170s

Reproducible: Always

[Comment 1 James Browning 2020-12-12 21:05:47 UTC]

IMO not an NTPsec issue. NTPsec does not respect GNU autoscrap MAKEOPTS. Kick it over to the waf eclass maintainer(s) and ask them to handle it, or write and become the maintenance slave for autoscrap build if you are so inclined.

[Comment 2 James Browning 2021-07-01 15:33:54 UTC]

Created attachment 720819 [details, diff]
proposed patch to make ntpsec respect MAKEOPTS

Signed-off-by: James Browning <[e-mail]>

[Comment 3 Sam James 2022-12-30 06:30:57 UTC]

(In reply to James Browning from comment #1)
> IMO not an NTPsec issue. NTPsec does not respect GNU autoscrap MAKEOPTS.
> Kick it over to the waf eclass maintainer(s) and ask them to handle it, or
> write and become the maintenance slave for autoscrap build if you are so
> inclined.

Yeah, you're bang on.

I think this got fixed properly in waf-utils.eclass with:


commit 7e8083cd0516d7ea15e0e7e735abfceaa1e9d08b
Author: Matthew Smith <[e-mail]>
Date:   Mon Oct 17 18:52:12 2022 +0100

    waf-utils.eclass: set PYTHONHASHSEED environment variable

    waf relies on Python set order, so let's make it consistent to avoid
    brittle builds.

    Added into existing phase functions instead of pkg_setup to retain
    compatibility with existing ebuilds.

    Signed-off-by: Matthew Smith <[e-mail]>

commit c8bbd4cf6d3b4f87a78dddf7d85fabe68fc27b20
Author: Matthew Smith <[e-mail]>
Date:   Mon Oct 17 18:49:38 2022 +0100

    waf-utils.eclass: set --jobs=1 for configure and install

    MAKEOPTS was only respected for src_compile, leading to out-of-memory
    issues for some users. Force number of concurrent jobs to 1 in src_configure
    and src_install phases as it doesn't provide much of a benefit anyway.

    Closes: https://bugs.gentoo.org/715542
    Signed-off-by: Matthew Smith <[e-mail]>

[Comment 4 Larry the Git Cow 2022-12-30 06:33:32 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e5dc88331ebe51f7b98a4aaca17657b7e914d63

commit 3e5dc88331ebe51f7b98a4aaca17657b7e914d63
Author:     Sam James <[e-mail]>
AuthorDate: 2022-12-30 06:29:54 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-12-30 06:32:19 +0000

    net-misc/ntpsec: add 1.2.2
    
    Closes: https://bugs.gentoo.org/679510
    Closes: https://bugs.gentoo.org/753854
    Closes: https://bugs.gentoo.org/806037
    Closes: https://bugs.gentoo.org/839597
    Closes: https://bugs.gentoo.org/885879
    Signed-off-by: Sam James <[e-mail]>

 net-misc/ntpsec/Manifest            |   1 +
 net-misc/ntpsec/ntpsec-1.2.2.ebuild | 163 ++++++++++++++++++++++++++++++++++++
 net-misc/ntpsec/ntpsec-9999.ebuild  |   3 +-
 3 files changed, 165 insertions(+), 2 deletions(-)