Bug 753830

Summary:	mail-filter/rspamd Please use bundled lua-lpeg module
Product:	Gentoo Linux	Reporter:	Marcin Deranek <marcin.deranek>
Component:	Current packages	Assignee:	Christian Roessner <c>
Status:	RESOLVED FIXED
Severity:	normal	CC:	arkamar, jstein, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/rspamd/rspamd/issues/3533
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=752957 https://github.com/gentoo/gentoo/pull/18231
Whiteboard:
Package list:		Runtime testing required:	---

Description Marcin Deranek 2020-11-10 11:50:15 UTC

Rspamd uses some of Lua modules which are patched. Full list can be found at https://github.com/rspamd/rspamd/blob/master/contrib/DEPENDENCY_INFO.md
System dev-lua/lpeg causes errors in rspamd and we need to use bundled version to avoid them. Sample errors:

2020-10-27 20:53:27 #7500(controller) <330dbb>; csession; rspamd_re_cache_check_lua_condition: cannot call for re_cache_check_lua_condition for re \b[13LM][1-9A-Za-z]{25,34}\b: error when calling lua fun ction from /var/tmp/portage/mail-filter/rspamd-2.6-r1/work/rspamd-2.6/src/libserver/re_cache.c:567: /usr/share/rspamd/rules/bitcoin.lua:190: bad argument #2 to 'str_trim' (string expected, got userdata); trace: [1]:{[C]:-1 - str_trim [C]}; [2]:{/usr/share/rspamd/rules/bitcoin.lua:190 - <unknown> [Lua]};

or

2020-10-29 13:58:51 #40735(main) <rwzsya>; map; lua_map_fin: call to map fin function failed (2): /usr/share/rspamd/plugins/phishing.lua:438: bad argument #2 to 'rspamd_str_split_fun' (string expected, got userdata); trace: [1]:{[C]:-1 - rspamd_str_split_fun [C]}; [2]:{/usr/share/rspamd/plugins/phishing.lua:438 - <unknown> [Lua]};

Reproducible: Always

Steps to Reproduce:
See linked URL for details

Comment 1 Larry the Git Cow gentoo-dev

2020-11-20 10:12:02 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4c876bf9fc2573be36d6ebd504df3cc3535dc7d2

commit 4c876bf9fc2573be36d6ebd504df3cc3535dc7d2
Author:     Petr Vaněk <arkamar@atlas.cz>
AuthorDate: 2020-11-12 13:12:58 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-11-20 10:01:15 +0000

    mail-filter/rspamd: use bundled lua-lpeg, bug #753830
    
    Closes: https://bugs.gentoo.org/753830
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../rspamd/files/rspamd-2.5-unbundle-lua.patch     | 60 +++------------------
 .../rspamd/files/rspamd-2.6-unbundle-lua.patch     | 62 +++-------------------
 .../{rspamd-2.5.ebuild => rspamd-2.5-r1.ebuild}    |  4 +-
 .../{rspamd-2.6-r1.ebuild => rspamd-2.6-r2.ebuild} |  4 +-
 4 files changed, 16 insertions(+), 114 deletions(-)