Bug 753821

Summary:	dev-libs/libffi-3.3-r2: test for ROOT is bogus on eapi7
Product:	Gentoo Linux	Reporter:	Pacho Ramos <pacho>
Component:	Current packages	Assignee:	Gentoo Toolchain Maintainers <toolchain>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Pacho Ramos gentoo-dev

2020-11-10 10:48:42 UTC

due to EAPI7
https://mgorny.pl/articles/the-ultimate-guide-to-eapi-7.html#d-ed-root-eroot-no-longer-have-a-trailing-slash

ROOT won't have /, the test in ebuild should be updated then

Thanks

Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev

2020-11-10 21:52:55 UTC

Good catch! I think all of pkg_setup() can go as it's from times when libffi was installed as part of gcc.

Comment 2 Larry the Git Cow gentoo-dev

2020-11-10 22:22:27 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=56470165472b6d99db739c36b1ceef77b080706c

commit 56470165472b6d99db739c36b1ceef77b080706c
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-11-10 22:21:59 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-11-10 22:22:22 +0000

    dev-libs/libffi: drop no-op pkg_setup()
    
    Due to a bug in handling empty ${ROOT} pkg_setup() was a no-op.
    It's not a big problem as it used to check for libffi presence
    outside package manager (usually due to old gcc bundlibg libffi).
    
    The check should should be redundant on modern toolchain.
    
    Reported-by: Pacho Ramos
    Closes: https://bugs.gentoo.org/753821
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 dev-libs/libffi/libffi-3.3-r2.ebuild | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)