Bug 753608

Summary:	sys-boot/lilo: Needs to set QA_FLAGS_IGNORED
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Joshua Kinard <kumba>
Status:	RESOLVED FIXED
Severity:	normal	CC:	base-system, peter
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	59506
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2020-11-08 21:50:10 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-boot/lilo-24.2 does not respect CFLAGS.
Discovered on: amd64 (internal ref: ci)

NOTE:
To reproduce this issue you may want to add "-frecord-gcc-switches" to CFLAGS/CXXFLAGS/FFLAGS/FCFLAGS. If this is not something about c/c++ context see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect CFLAGS.

Comment 1 Agostino Sarubbo gentoo-dev

2020-11-08 21:50:13 UTC

Created attachment 670514 [details]
build.log

build log and emerge --info

Comment 2 Joshua Kinard gentoo-dev

2020-11-09 02:14:15 UTC

I am not sure that we want arbitrary CFLAGS getting used with a bootloader.  This is one of the few cases where you want to respect upstream's choices.  There's no real performance benefit since bootloaders are only used during boot and you generally want them to work the first time around...

Comment 3 Agostino Sarubbo gentoo-dev

2020-11-09 07:28:35 UTC

(In reply to Joshua Kinard from comment #2)
> I am not sure that we want arbitrary CFLAGS getting used with a bootloader. 
> This is one of the few cases where you want to respect upstream's choices. 
> There's no real performance benefit since bootloaders are only used during
> boot and you generally want them to work the first time around...

If there is no benefit, hide the qa notice is enough ;)

Comment 4 Peter Stuge 2021-06-02 01:54:30 UTC

(In reply to Agostino Sarubbo from comment #3)
> If there is no benefit, hide the qa notice is enough ;)

Please change summary to "sys-boot/lilo-24.2 does not set QA_FLAGS_IGNORED" ?

Comment 5 Larry the Git Cow gentoo-dev

2021-06-06 20:01:56 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf9a976299a0277b616aee32caf98f9ab4585428

commit bf9a976299a0277b616aee32caf98f9ab4585428
Author:     Joshua Kinard <kumba@gentoo.org>
AuthorDate: 2021-06-06 20:01:25 +0000
Commit:     Joshua Kinard <kumba@gentoo.org>
CommitDate: 2021-06-06 20:01:45 +0000

    sys-boot/lilo: Fix bugs #753608 and #715580
    
    Add QA_FLAGS_IGNORED for '/sbin/lilo' to address Bug #753608 and
    Add a small patch to check for '__GLIBC__' before a printf() call
    that references it to avoid compilation errors on non-glibc systems
    to fix Bug #715580.  Also remove the unneeded 'eutils' inherit.
    
    Closes: https://bugs.gentoo.org/753608
    Closes: https://bugs.gentoo.org/715580
    Signed-off-by: Joshua Kinard <kumba@gentoo.org>
    Package-Manager: Portage-3.0.19, Repoman-3.0.3

 .../lilo/files/lilo-24.x-check-for-__GLIBC__.patch     | 18 ++++++++++++++++++
 sys-boot/lilo/lilo-24.2.ebuild                         |  7 ++++++-
 2 files changed, 24 insertions(+), 1 deletion(-)