Bug 753479

Summary:	dev-util/spirv-tools-2020.5_pre20200922: shouldn't install static libs instead of shared
Product:	Gentoo Linux	Reporter:	Ionen Wolkens <ionen>
Component:	Current packages	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dan, jstein, phobosk, sarnex
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log and emerge --info

Description Ionen Wolkens gentoo-dev

2020-11-07 14:23:52 UTC

Created attachment 670310 [details]
build.log and emerge --info

Upstream issue/tracker:
https://github.com/KhronosGroup/SPIRV-Tools/issues/3909
> To summarize the above:
> BUILD_SHARED_LIBS is not properly respected, and distro packages are now broken
spirv-tools-2020.3:
/usr/lib64/libSPIRV-Tools-link.so
/usr/lib64/libSPIRV-Tools-opt.so
/usr/lib64/libSPIRV-Tools-reduce.so
/usr/lib64/libSPIRV-Tools-shared.so
/usr/lib64/libSPIRV-Tools.so

spirv-tools-2020.5_pre20200922:
/usr/lib64/libSPIRV-Tools-link.a
/usr/lib64/libSPIRV-Tools-opt.a
/usr/lib64/libSPIRV-Tools-reduce.a
/usr/lib64/libSPIRV-Tools-shared.so
/usr/lib64/libSPIRV-Tools.a

This notably cause unsolvable @perserved-rebuilds and media-video/mpv[vulkan] fails to build if gone.

Comment 1 PhobosK 2020-11-07 16:17:40 UTC

Same goes for =dev-util/spirv-tools-9999

Comment 2 Larry the Git Cow gentoo-dev

2020-11-07 17:10:43 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=babddbcf14af8401381687c75e4bfe1cd2689d4b

commit babddbcf14af8401381687c75e4bfe1cd2689d4b
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2020-11-07 17:06:29 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2020-11-07 17:10:23 +0000

    dev-util/spirv-tools: Update snapshot
    
    Closes: https://bugs.gentoo.org/753479
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 dev-util/spirv-tools/Manifest                      |   2 +-
 .../files/spirv-tools-2020.5-Fix-build.patch       | 373 ---------------------
 ...build => spirv-tools-2020.5_pre20201107.ebuild} |   8 +-
 dev-util/spirv-tools/spirv-tools-9999.ebuild       |  11 +-
 4 files changed, 11 insertions(+), 383 deletions(-)

Comment 3 Ionen Wolkens gentoo-dev

2020-11-07 18:15:36 UTC

To be pedantic the -DBUILD_SHARED_LIBS=ON can be removed, this is already set by the cmake eclasses through the generated gentoo_common_config.cmake

But thanks for quick fix, working as expected now :)

Comment 4 Nick Sarnie gentoo-dev

2020-11-07 19:06:45 UTC

Thanks, I added it just to be safe. Upstream is an absolute shitshow so I want to make sure we lock down everything we need

Comment 5 Nick Sarnie gentoo-dev

2020-11-08 04:00:05 UTC

*** Bug 753527 has been marked as a duplicate of this bug. ***