Summary: | media-video/ffmpeg-4.3.1: USE=vulkan doesn't enable vulkan filters | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Gregory Beauregard <gentoobugs> |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | atoth, jstein, sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Gregory Beauregard
2020-10-19 22:36:57 UTC
Apparently there's some weirdness with glslang not supporting pkgconfig. Upstream referred me to reverting commit 98ea1a662ee172961feaa374fe8d26078838d250 as fixing building with --enable-libglslang on debian, and that worked for me on Gentoo as well. Will probably need to be inspected what this does and included as a .patch/some other method to fixup the glslang detection for our specific packaging whenever this gets looked at. (In reply to Gregory Beauregard from comment #1) > Apparently there's some weirdness with glslang not supporting pkgconfig. > Upstream referred me to reverting commit > 98ea1a662ee172961feaa374fe8d26078838d250 as fixing building with > --enable-libglslang on debian, and that worked for me on Gentoo as well. > Will probably need to be inspected what this does and included as a > .patch/some other method to fixup the glslang detection for our specific > packaging whenever this gets looked at. So as far as I know, a patch that reverts this commit (it just removes a couple things from a line), a dev-util/glslang dependency, and a dev-util/spirv-tools dependency are what's needed here. The spirv-tools dependency isn't obvious, but it's required. (In reply to Gregory Beauregard from comment #1) > Apparently there's some weirdness with glslang not supporting pkgconfig. > Upstream referred me to reverting commit > 98ea1a662ee172961feaa374fe8d26078838d250 as fixing building with > --enable-libglslang on debian, and that worked for me on Gentoo as well. > Will probably need to be inspected what this does and included as a > .patch/some other method to fixup the glslang detection for our specific > packaging whenever this gets looked at. Debian in the last week merged a new version of glslang where this hack/revert isn't required anymore, so depending on when someone gets to this bug it's worth double checking if the current version of glslang in-tree still requires this (currently it does). (In reply to Gregory Beauregard from comment #3) > (In reply to Gregory Beauregard from comment #1) > > Apparently there's some weirdness with glslang not supporting pkgconfig. > > Upstream referred me to reverting commit > > 98ea1a662ee172961feaa374fe8d26078838d250 as fixing building with > > --enable-libglslang on debian, and that worked for me on Gentoo as well. > > Will probably need to be inspected what this does and included as a > > .patch/some other method to fixup the glslang detection for our specific > > packaging whenever this gets looked at. > > Debian in the last week merged a new version of glslang where this > hack/revert isn't required anymore, so depending on when someone gets to > this bug it's worth double checking if the current version of glslang > in-tree still requires this (currently it does). As of glslang 11.2 (in-tree) this workaround is still needed. I suspect Debian may be making downstream changes to the package, but I haven't had a chance to look into the details yet. Great platform to learn new things. https://bit.ly/2VrIOdB Okay, packaging has changed in ffmpeg and vulkan stuff is integrated so for 9999/next ffmpeg release the status for enabling the vulkan filters is (in addition to --enable-vulkan): add dependencies on: dev-util/spirv-tools media-libs/shaderc add to configure options: --enable-libshaderc For the libplacebo filter (that depends on vulkan and you almost certainly want): add dependency on: media-libs/libplacebo (9999 for now, needs pending release) add to configure options: --enable-libplacebo libplacebo support could be a separate use flag or enabled with vulkan I'll update when libplacebo release happens In 4.4.1-r1 version new vulkan filters are still not built and both --enable-libshaderc and --enable-libplacebo are not recognized by ./configure Iade Those instructions are for 9999/next (since released as ffmpeg 5.0) (In reply to Gregory Beauregard from comment #6) > Okay, packaging has changed in ffmpeg and vulkan stuff is integrated so for > 9999/next ffmpeg release the status for enabling the vulkan filters is (in > addition to --enable-vulkan): > > add dependencies on: > dev-util/spirv-tools > media-libs/shaderc > > add to configure options: > --enable-libshaderc > > For the libplacebo filter (that depends on vulkan and you almost certainly > want): > add dependency on: > media-libs/libplacebo (9999 for now, needs pending release) > add to configure options: > --enable-libplacebo > > libplacebo support could be a separate use flag or enabled with vulkan > > I'll update when libplacebo release happens in addition to all this, media-libs/nv-codec-headers is going to need bumped to at least 11.1.5.1 to get vulkan working for nvidia users. Some timeline semaphore stuff was added that is needed for vulkan. |