Bug 750125

Summary:	net-misc/unison[gtk] doesn't actually build the GTK GUI (PATCH)
Product:	Gentoo Linux	Reporter:	Maciej S. Szmigiero <mail>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	major	CC:	jstein, sam
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Maciej S. Szmigiero 2020-10-19 13:31:10 UTC

At least with net-misc/unison-2.51.3_rc2 (and earlier versions likely, too) enabling "gtk" USE flag doesn't actually build the GTK GUI.

This is because the package ebuild calls "make" on the default target, while the unison top-level Makefile overrides the UISTYLE var to text for this target:
> default: text
> 
> text:
>     $(MAKE) -C src UISTYLE=text


In order to have a switchable UISTYLE the "all" target should be built instead,
the required ebuild change is below:
>  src_compile() {
>         local myconf
>  
> +       myconf="all"
> +
>        if use threads; then
>                myconf="$myconf THREADS=true"
>        fi

The above fixes the GTK build.

Comment 1 Larry the Git Cow gentoo-dev

2020-10-20 03:09:25 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dfcfaa586a6aee2b81100c59995480f632f669dc

commit dfcfaa586a6aee2b81100c59995480f632f669dc
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-10-20 03:08:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-10-20 03:09:22 +0000

    net-misc/unison: fix .desktop and GUI build
    
    Closes: https://bugs.gentoo.org/360161
    Closes: https://bugs.gentoo.org/750125
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Sam James <sam@gentoo.org>

 .../unison/{unison-2.48.15_p4.ebuild => unison-2.48.15_p4-r1.ebuild}  | 4 ++--
 net-misc/unison/unison-2.51.3_rc3.ebuild                              | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)