Bug 749165

Summary:	sys-auth/yubico-piv-tool-2.1.1-r2 uses -Werror for build
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Marek Szuba (RETIRED) <marecki>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867

Description Agostino Sarubbo gentoo-dev

2020-10-15 05:39:01 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-auth/yubico-piv-tool-2.1.1-r2 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

Comment 1 Larry the Git Cow gentoo-dev

2020-10-15 14:27:23 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2cbe4d3d2f240b4d74b518b3137684d8b2b599f6

commit 2cbe4d3d2f240b4d74b518b3137684d8b2b599f6
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-10-15 14:19:31 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-10-15 14:19:31 +0000

    sys-auth/yubico-piv-tool: remove -Werror from compiler flags
    
    Closes: https://bugs.gentoo.org/749165
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 .../files/yubico-piv-tool-2.1.1-no-Werror.patch               | 11 +++++++++++
 sys-auth/yubico-piv-tool/yubico-piv-tool-2.1.1-r2.ebuild      |  1 +
 2 files changed, 12 insertions(+)