Bug 746770

Summary:	dev-embedded/stlink-1.6.0 uses -Werror for build
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Alexey Shvetsov <alexxy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867

Description Agostino Sarubbo gentoo-dev

2020-10-05 20:35:01 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-embedded/stlink-1.6.0 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

Comment 1 Larry the Git Cow gentoo-dev

2022-06-11 05:58:18 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=60a72592945b8287664100188338baebb5b54503

commit 60a72592945b8287664100188338baebb5b54503
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-11 05:55:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-11 05:55:14 +0000

    dev-embedded/stlink: drop Werror
    
    Closes: https://bugs.gentoo.org/746770
    Signed-off-by: Sam James <sam@gentoo.org>

 .../stlink/files/stlink-1.7.0-no-werror.patch        | 20 ++++++++++++++++++++
 dev-embedded/stlink/stlink-1.7.0.ebuild              |  6 +++++-
 2 files changed, 25 insertions(+), 1 deletion(-)