| Summary: | media-video/obs-studio-26.1.0: version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | François Périchon <lebarjack> |
| Component: | Current packages | Assignee: | Chiitoo <chiitoo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugzilla, dschridde+gentoobugs, lebarjack, polynomial-c |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=717002 https://github.com/gentoo/gentoo/pull/18883 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | obs ebuild to support submodules | ||
|
Description
François Périchon
2020-10-01 14:53:36 UTC
I've been holding this off a bit due to ALSA configuration being currently broken [1]. I do have a dirty hack to fix it, but I'm not sure I should ship that with the ebuild. I'll give it some more time and thought. Thanks for the report though! 1. https://github.com/obsproject/obs-studio/issues/3485 I've got this one working for me. I just copied the v25 ebuild file. I've also commented out the v25 patch (which seems to be for GCC 10) and everything is working for me but,I'm on GCC 9.3. I'm not using (or trying to use) the browser plugin mentioned in bug 717002 (In reply to edoceo from comment #2) > I've got this one working for me. I just copied the v25 ebuild file. Are you using ALSA only or PulseAudio? If ALSA only, are you able to add ALSA sources without any issues? (In reply to Chiitoo from comment #1) > I've been holding this off a bit due to ALSA configuration being currently > broken [1]. I do have a dirty hack to fix it, but I'm not sure I should > ship that with the ebuild. > > 1. https://github.com/obsproject/obs-studio/issues/3485 Would it be safe to mask the alsa useflag for now, until upstream has sorted this out? I /might/ be more inclined to implement one of my hack'ish fixes for when building with ALSA enabled, but it will mean that one can not use PulseAudio as well in that case, meaning I should probably disallow building with both (does anyone even do that on purpose?). I hoped that the issue was fixed weeks ago, but since it's taking this long, I'll figure out something probably for 26.1.0, which might be out soon. Created attachment 678064 [details]
obs ebuild to support submodules
Here is an ebuild for obs-studio which:
- bumps version to 26.0.2
- re-write to use git instead of tarball releases
- adds 'browser' use flag for providing obs-browser support
(dependencies borrowed from #717002 thanks!)
1. Unlike PR in #717002, I decided to use git submodules so we do not need to asset the commit hash for the plugins/obs-browser. (And be required to update it for every incremental version change.
This way we leave the versioning to upstream, for all submodules.
2. Regarding the `alsa` only question. I can confirm that building without pulseaudio support, and just alsa support results in a crash for v26.0.2.
But when building with both alsa and pulseaudio, alsa does not crash, and works correctly, as does pulseaudio.
2.a building with just pulseaudio support also works fine.
(In reply to Tim from comment #6) > 2. Regarding the `alsa` only question. I can confirm that building without > pulseaudio support, and just alsa support results in a crash for v26.0.2. > But when building with both alsa and pulseaudio, alsa does not crash, and > works correctly, as does pulseaudio. > 2.a building with just pulseaudio support also works fine. So from the sound of it, you'd need Chiitoo's patch only if you're building with USE=-pulseaudio anyway, so there's no real conflict per se. That said, alternatively, I wonder if media-sound/apulse provides enough to satisfy the pulseaudio requirement and make the question moot? Sorry, I somehow missed the mail about comment 6. There are quite a few fun things going on at once now, most waiting for something else to happen first (version bump, lua, python, browser). Since it has taken this long and nothing has happened with the ALSA and Python issues, I'll try to make a decision with regards to those /real/ soon. I had hoped for the browser thing to get in by now, before I do anything else. If you believe this is a better way to go with it, please also mention it in the PR (I'll try to compare them /real/ soon as well!). As for ALSA, yeah, I'd imagine building with both will work, as OBS will probably just use PulseAudio in that case (you might see some weird stuff going on with ALSA sources in the source toolbar under the video area). Indeed, I'm thinking of patching only when ALSA is enabled, and add a warning about it so that people will hopefully not go complain upstream about it (well, maybe they should, but the issue is already known there so I'm not sure that it would help). (In reply to Tim from comment #6) > 1. Unlike PR in #717002, I decided to use git submodules so we do not need > to asset the commit hash for the plugins/obs-browser. (And be required to > update it for every incremental version change. > This way we leave the versioning to upstream, for all submodules. I finally managed to have a better look, and since this looks like it's making git and friends a hard dependency, I think at this time I prefer the alternative. I'll keep this in mind for the future though. Thanks! (In reply to Chiitoo from comment #9) > (In reply to Tim from comment #6) > > 1. Unlike PR in #717002, I decided to use git submodules so we do not need > > to asset the commit hash for the plugins/obs-browser. (And be required to > > update it for every incremental version change. > > This way we leave the versioning to upstream, for all submodules. > > I finally managed to have a better look, and since this looks like it's > making git and friends a hard dependency, I think at this time I prefer the > alternative. > > I'll keep this in mind for the future though. > > Thanks! I'm unsure of netiquette regarding replying to bugs, so excuse me if I'm out of line. No worries! After seeing #717002 it's definitely not as elegant. I think choosing a patch with only a SRC_URI dependency is the correct move here rather than my git & SRC_URI version. I also _personally_ think merging the latest version to have the browser source in is a priority, then deploy your fix for the alsa dependency/issue. (Feel free to add me as a CC for that bug, if you need extra help testing it) Cheers! The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d071aba9e0ce3f910469fd95ba391456ae23235a commit d071aba9e0ce3f910469fd95ba391456ae23235a Author: Jimi Huotari <chiitoo@gentoo.org> AuthorDate: 2021-01-31 14:15:40 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2021-01-31 15:01:55 +0000 media-video/obs-studio: add version 26.1.2 Closes: https://bugs.gentoo.org/745996 Closes: https://bugs.gentoo.org/761939 Package-Manager: Portage-3.0.14, Repoman-3.0.2 Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> Closes: https://github.com/gentoo/gentoo/pull/18883 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> media-video/obs-studio/Manifest | 1 + .../files/obs-studio-26.1.2-fix-alsa-crash.patch | 30 ++++ media-video/obs-studio/obs-studio-26.1.2.ebuild | 155 +++++++++++++++++++++ 3 files changed, 186 insertions(+) |
