Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 745459

Summary: net-print/hplip-3.20.6-r2: hplip-3.20.6-python-includes.patch introduces Bashisms into configure script
Product: Gentoo Linux Reporter: Matt Whitlock <gentoo>
Component: Current packagesAssignee: Daniel Pielmeier <billie>
Status: RESOLVED FIXED    
Severity: normal CC: alexander, jstein, printing
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 526268    
Attachments: hplip-3.20.6-python-includes_no-bashisms.patch

Description Matt Whitlock 2020-09-29 18:07:19 UTC
Created attachment 663187 [details, diff]
hplip-3.20.6-python-includes_no-bashisms.patch

The "hplip-3.20.6-python-includes.patch" distributed in hplip-3.20.6-patches-1.tar.xz introduces a Bashism to the configure script that fails when /bin/sh is not Bash:

checking for python3-config... /var/tmp/portage/net-print/hplip-3.20.6-r2/temp/python3.8/bin/python3-config
./configure: 17886: test: X-I/usr/include/python3.8 -I/usr/include/python3.8: unexpected operator
./configure: 17891: test: X -lcrypt -lpthread -ldl  -lutil -lm -lm : unexpected operator
yes
checking whether /usr/bin/python3.8 version is >= 2.2... yes
checking for /usr/bin/python3.8 version... 3.8


The attached patch removes the Bashisms from "hplip-3.20.6-python-includes.patch" and resolves the configure-time errors when /bin/sh is Dash 0.5.11.2.
Comment 1 Larry the Git Cow gentoo-dev 2020-09-30 19:05:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8717fdedc058885a88a29926175206579cd25d50

commit 8717fdedc058885a88a29926175206579cd25d50
Author:     Daniel Pielmeier <billie@gentoo.org>
AuthorDate: 2020-09-30 19:05:27 +0000
Commit:     Daniel Pielmeier <billie@gentoo.org>
CommitDate: 2020-09-30 19:05:27 +0000

    net-print/hplip: Revision bump to hplip-3.20.6-r3.
    
    Thanks to Matt Whitlock for the report.
    
    Closes: https://bugs.gentoo.org/745459
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Daniel Pielmeier <billie@gentoo.org>

 net-print/hplip/Manifest               |   1 +
 net-print/hplip/hplip-3.20.6-r3.ebuild | 278 +++++++++++++++++++++++++++++++++
 2 files changed, 279 insertions(+)