Bug 745093

Summary:	dev-libs/aws-c-common-0.4.57 uses -Werror for build
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Sven Eden <sven.eden>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/17707
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867

Description Agostino Sarubbo gentoo-dev

2020-09-28 11:48:57 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/aws-c-common-0.4.57 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

Comment 1 Sven Eden 2020-09-29 08:07:59 UTC

*** Bug 745090 has been marked as a duplicate of this bug. ***

Comment 2 Larry the Git Cow gentoo-dev

2020-09-30 07:06:54 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ac980372dc0487ad5f8f773dba883bb7f32a679f

commit ac980372dc0487ad5f8f773dba883bb7f32a679f
Author:     Sven Eden <sven.eden@prydeworx.com>
AuthorDate: 2020-09-29 07:32:46 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-09-30 07:06:39 +0000

    dev-libs/aws-c-common: Remove -Werror from build FLAGS
    
    Issue: dev-libs/aws-c-common-0.4.57 uses -Werror for build.
    Discovered on: amd64 (internal ref: ci)
    
    -Werror is not recommended for releases and should always be disabled
    when encountered in build-logs, because there are numerous cases
    where this breaks without purpose.
    
    Closes: https://bugs.gentoo.org/745093
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Sven Eden <sven.eden@prydeworx.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 ...s-c-common-0.4.57.ebuild => aws-c-common-0.4.57-r1.ebuild} |  4 ++++
 .../files/aws-c-common-0.4.57-remove-Werror-CFLAG.patch       | 11 +++++++++++
 2 files changed, 15 insertions(+)