Bug 745087

Summary:	dev-libs/aws-sdk-cpp-1.8.46-r1 uses -Werror for build
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Sven Eden <sven.eden>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, proxy-maint, sven.eden
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/17707
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867

Description Agostino Sarubbo gentoo-dev

2020-09-28 11:48:42 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/aws-sdk-cpp-1.8.46-r1 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

Comment 1 Sven Eden 2020-09-28 19:23:11 UTC

Thanks for the link. The flag will be removed on the next bump.

(Which isn't far away, as the AWS-SDK is very speedy in releases...)

Comment 2 Sven Eden 2020-09-29 08:30:42 UTC

Not only did aws-c-common leak a -Werror into the build system, see bug 745093, but the SDK also adds this flag.

Great for debugging, but not for a release, agreed.

Also the dependency on aws-checksums is wrong, it'll get fixed, too.

Comment 3 Larry the Git Cow gentoo-dev

2020-09-30 07:06:52 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d37df88ee5b07c4286698a8332f1893066a75217

commit d37df88ee5b07c4286698a8332f1893066a75217
Author:     Sven Eden <sven.eden@prydeworx.com>
AuthorDate: 2020-09-29 08:53:02 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-09-30 07:06:44 +0000

    dev-libs/aws-sdk-cpp: Fix dependency and build FLAGS
    
    * The dependency on dev-libs/aws-checkums has been fixed
    * The build system introduces -Werror into the build system, which
      has been removed.
    
    Closes: https://bugs.gentoo.org/745087
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Sven Eden <sven.eden@prydeworx.com>
    Closes: https://github.com/gentoo/gentoo/pull/17707
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 ...8.46-r1.ebuild => aws-sdk-cpp-1.8.46-r2.ebuild} |  3 ++-
 ...s-sdk-cpp-1.8.46-remove_Werror_from_FLAGS.patch | 30 ++++++++++++++++++++++
 2 files changed, 32 insertions(+), 1 deletion(-)