Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 744946

Summary: net-libs/mbedtls-2.24.0 uses -Werror for build
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: Current packagesAssignee: Anthony Basile <blueness>
Status: RESOLVED FIXED    
Severity: normal CC: esigra, slyfox
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 260867, 732706    

Description Agostino Sarubbo gentoo-dev 2020-09-27 13:23:38 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/mbedtls-2.24.0 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2020-10-13 21:56:29 UTC 
The -Werror also happens to break the build on gcc-11: https://github.com/ARMmbed/mbedtls/issues/3782
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2020-11-16 08:05:07 UTC 
CMakeLists.txt already exposes a mechanism to disable -Werror. The following seems to work:

--- a/net-libs/mbedtls/mbedtls-2.24.0.ebuild
+++ b/net-libs/mbedtls/mbedtls-2.24.0.ebuild
@@ -53,6 +53,7 @@ multilib_src_configure() {
                -DUSE_SHARED_MBEDTLS_LIBRARY=ON
                -DINSTALL_MBEDTLS_HEADERS=ON
                -DLIB_INSTALL_DIR="${EPREFIX}/usr/$(get_libdir)"
+               -DMBEDTLS_FATAL_WARNINGS=OFF
        )

        cmake_src_configure
Comment 4 Larry the Git Cow gentoo-dev 2021-09-19 07:12:51 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93f6e77da684f70ea10256e40f88cab0d45573d9

commit 93f6e77da684f70ea10256e40f88cab0d45573d9
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2021-09-19 06:23:03 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2021-09-19 07:12:34 +0000

    net-libs/mbedtls: Remove old
    
    Closes: https://bugs.gentoo.org/744946
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Andreas K. Huettel <dilfridge@gentoo.org>

 net-libs/mbedtls/Manifest               |  2 -
 net-libs/mbedtls/mbedtls-2.16.10.ebuild | 93 ---------------------------------
 net-libs/mbedtls/mbedtls-2.16.11.ebuild | 93 ---------------------------------
 3 files changed, 188 deletions(-)