Bug 744928

Summary:	dev-libs/rocr-runtime-4.3.0 uses -Werror for build
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Craig Andrews <candrews>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, gentoo
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/28706
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867

Description Agostino Sarubbo gentoo-dev

2020-09-27 05:26:41 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/rocr-runtime-3.8.0 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

Comment 1 Agostino Sarubbo gentoo-dev

2021-12-19 22:11:23 UTC

/var/tmp/portage/dev-libs/rocr-runtime-4.3.0/work/ROCR-Runtime-rocm-4.3.0/src/loader/executable.cpp:72:23: error: variable 'function_needs_a_side_effect' set but not used [-Werror,-Wunused-but-set-variable]

Comment 2 Agostino Sarubbo gentoo-dev

2021-12-19 22:11:28 UTC

tinderbox has reproduced this issue with version 4.3.0 - Updating summary.

Comment 3 Larry the Git Cow gentoo-dev

2022-12-19 14:00:38 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e59d3dedf0149693d186ea22a2003fd7abef10c2

commit e59d3dedf0149693d186ea22a2003fd7abef10c2
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-12-19 08:01:56 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-12-19 14:00:00 +0000

    dev-libs/rocr-runtime: drop versions 3* and 4*
    
    Closes: https://bugs.gentoo.org/874513
    Closes: https://bugs.gentoo.org/744928
    Closes: https://bugs.gentoo.org/832810
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-libs/rocr-runtime/Manifest                     |  8 ----
 .../rocr-runtime-3.7.0-cmake-install-paths.patch   | 53 ----------------------
 .../rocr-runtime-4.1.0-cmake-install-paths.patch   | 53 ----------------------
 dev-libs/rocr-runtime/rocr-runtime-3.10.0.ebuild   | 47 -------------------
 dev-libs/rocr-runtime/rocr-runtime-3.8.0.ebuild    | 47 -------------------
 dev-libs/rocr-runtime/rocr-runtime-3.9.0.ebuild    | 47 -------------------
 dev-libs/rocr-runtime/rocr-runtime-4.0.0.ebuild    | 47 -------------------
 dev-libs/rocr-runtime/rocr-runtime-4.1.0.ebuild    | 53 ----------------------
 dev-libs/rocr-runtime/rocr-runtime-4.2.0.ebuild    | 46 -------------------
 dev-libs/rocr-runtime/rocr-runtime-4.3.0.ebuild    | 45 ------------------
 dev-libs/rocr-runtime/rocr-runtime-4.5.2.ebuild    | 45 ------------------
 11 files changed, 491 deletions(-)