Summary: | net-print/ql570: cups driver for Brother QL-570 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ortwin Glueck <odi> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | jstein, printing |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://forums.gentoo.org/viewtopic-p-8504065.html#8504065 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ebuild
ebuild v2 |
Description
Ortwin Glueck
2020-09-25 13:12:48 UTC
Created attachment 662365 [details]
ebuild
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck * Please remove obsolete lines * KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD * A bot can look for additional mistakes, if you upload a PR via github * "die" is missing on many lines * what is the LICENSE? License is the EULA that is presented on download page, hence the fetch restriction. What do I need to put into LICENSE in this case? Created attachment 662764 [details]
ebuild v2
added more die calls
the rest I don't care. It works for me.
|