Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 743535

Summary: <media-tv/kodi-19: (py2) cleanup
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Craig Andrews <candrews>
Status: RESOLVED FIXED    
Severity: normal CC: anarchy, canouble, k2k, kroemmelbein
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/17628
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 694800, 717538, 729672    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-09-19 10:36:17 UTC
What are our perspectives of removing py2 versions soonish?
Comment 1 Craig Andrews gentoo-dev 2020-09-20 20:50:31 UTC
The big problem is that upstream doesn't plan on releasing Kodi 19 (the first version which uses Python 3 and eliminates the dependency on Python 2) any time soon. They refuse to provide even an estimated date.

We could remove Kodi 18 from Gentoo, but then what do we about stable versions? 18.7 is stable on x86 and amd64. Would be stabilize an snapshot of an alpha version of Kodi 19 (currently, media-tv/kodi-19.0_alpha1_p20200916)?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-09-21 05:47:41 UTC
It wouldn't be the first time we stabilized a prerelease because upstream failed at releases.  Alternatively, drop to ~arch.
Comment 3 Craig Andrews gentoo-dev 2020-09-21 19:01:32 UTC
I'm seeing pushback on removing media-tv/kodi-18*... Are we sure that the Python 2 removal is sufficiently urgent to justify this action?
Comment 4 Karlson2k 2020-09-21 19:06:31 UTC
It's much better to drop to unstable kodi-18* and dependencies.
The infrastructure is not ready for unreleased version. Many addons are not ready, other things are need to be done. They will be finished with release on next Kodi version.
Removing Kodi-18 right now is not a good choice for (some of the) users.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-09-25 20:03:34 UTC
The primary problem is that kodi is blocking multiple vulnerabilities right now.  Whoever's using kodi-18 is turning his system into swiss cheese.  I wouldn't have that much problem with keeping it if you were able to eliminate the dep on pillow.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-10-30 11:23:28 UTC
@candrews, please either clean the old versions up or prepare a <-versioned mask for all versions depending on vulnerable pillow.
Comment 7 Larry the Git Cow gentoo-dev 2020-11-19 19:46:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47a1b34c41f1bf77204e0e90be03790db530141b

commit 47a1b34c41f1bf77204e0e90be03790db530141b
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2020-09-21 18:14:13 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2020-11-19 19:46:00 +0000

    media-tv/kodi: Cleanup kodi 18
    
    Kodi 18 requires python 2 which is EOL
    
    Closes: https://bugs.gentoo.org/743535
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 media-tv/kodi/Manifest                             |   5 -
 .../kodi/files/kodi-18-remove-useless-test.patch   |  51 ----
 media-tv/kodi/files/kodi-18.5-cassert.patch        |  42 ---
 media-tv/kodi/kodi-18.7.ebuild                     | 324 ---------------------
 media-tv/kodi/kodi-18.8.ebuild                     | 319 --------------------
 media-tv/kodi/kodi-18.9.ebuild                     | 319 --------------------
 6 files changed, 1060 deletions(-)