Bug 742404

Summary:	games-util/wit-3.02a adds -march=x86-64 to CFLAGS
Product:	Gentoo Linux	Reporter:	Alexey <alexey+gentoo>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	CONFIRMED ---
Severity:	normal	CC:	alexey+gentoo, sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log emerge --info

Description Alexey 2020-09-13 23:37:35 UTC

Created attachment 660051 [details]
build.log

>>> Install games-util/wit-3.02a into /home/user/gentoo/var/tmp/portage/games-util/wit-3.02a/image
make -j20 DESTDIR=/home/user/gentoo/var/tmp/portage/games-util/wit-3.02a/image install
gcc -O2 -pipe -O2 -pipe -fno-common -I./dclib -Wall -Wno-parentheses -Wno-unused-function -Isrc/libwbfs -Isrc -I./src/ui -I. -Iwork -march=x86-64  -MMD -DLARGE_FILES -D_FILE_OFFSET_BITS=64 -DWIT -DDEBUG_ASSERT -DEXTENDED_ERRORS=1 -D_7ZIP_ST=1 -D_LZMA_PROB32=1 -DTEST -c ./src/ui/gen-ui.c -o gen-ui.o

Also it seems to compile twice, first time in src_compile, and again in src_install, but using gcc this time instead of x86_64-pc-linux-gnu-gcc

-march=x86-64 comes from makefiles-local/Makefile.local.x86_64 included into Makefile.

Comment 1 Alexey 2020-09-13 23:40:06 UTC

Created attachment 660054 [details]
emerge --info

Comment 2 Alexey 2020-09-13 23:47:21 UTC

Some more issues with this package:
* it calls sudo if not root (relevant for Prefix)
* checks for existence of files like /usr/include/fuse.h and /usr/include/zlib.h to determine what should be supported (regardless of EPREFIX)
* cross-compilation won't work because it compiles and executes a C program during build to understand which of Makefiles to include

These really should be separate bugs, but I'm too lazy to upload build.log there again, sorry

Comment 3 Ionen Wolkens gentoo-dev

2020-09-14 02:26:16 UTC

I guess it could all be fixed by updating the makefile patch if someone wants to do it (no maintainer since last year).

There's also a new 3.03a+b version available to accumulate more issues but, as of the writing of this, seems upstream only released binary tarballs for 3.03a and would need a git snapshot for source
https://github.com/Wiimm/wiimms-iso-tools.git

Comment 4 Larry the Git Cow gentoo-dev

2020-10-03 22:51:02 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=48a5b269397a4dfb5c52a1e598c0d568bdfe6a9b

commit 48a5b269397a4dfb5c52a1e598c0d568bdfe6a9b
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2020-10-03 22:50:44 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-10-03 22:50:44 +0000

    games-util/wit: Fix -fno-common
    
    Bug: https://bugs.gentoo.org/742404
    Closes: https://bugs.gentoo.org/706610
    Closes: https://bugs.gentoo.org/724706
    Closes: https://bugs.gentoo.org/739408
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: David Seifert <soap@gentoo.org>

 games-util/wit/files/wit-3.02a-fno-common.patch    |  11 ++
 games-util/wit/files/wit-3.02a-makefile.patch      | 113 +++++++++++++++++++--
 ...c-stack.patch => wit-3.02a-no-exec-stack.patch} |   0
 games-util/wit/wit-3.02a.ebuild                    |  25 +++--
 4 files changed, 129 insertions(+), 20 deletions(-)