Bug 741522 – www-apps/gogs optimization help request

• Product: GURU
• Status: RESOLVED FIXED

[Description Reva Denis 2020-09-10 13:12:17 UTC]

Good daytime!
I had to ask GURU community to help optimizing www-apps/gogs. At this moment, despite I write ebuild, I'm not sure it works correctly.
The main issue is that I'm not sure that ebuild uses FHS correctly.
Also issue is number of distfiles required.
However, it builds and installs

Reproducible: Always

[Comment 1 Reva Denis 2020-09-10 13:12:45 UTC]

At this time www-apps/gogs in the dev branch.

[Comment 2 Andrew Nowa Ammerlaan 2020-09-10 14:56:45 UTC]

Overall looks good to me.

Curious though what this does as I can't find a reference to this function:

+ use mysql && enable_systemd_dep mysqld
+ use postgres && enable_systemd_dep postgresql

I think you got FHS correct, though I must admit that I'm not 100% sure as I'm not that experienced with the details of FHS.

Also, please don't use spaces as indentation, repoman doesn't like it very much:

www-apps/gogs/gogs-0.12.1.ebuild: line 12: Ebuild contains leading spaces
www-apps/gogs/gogs-0.12.1.ebuild: line 13: Ebuild contains leading spaces
www-apps/gogs/gogs-0.12.1.ebuild: line 14: Ebuild contains leading spaces
<snip>
www-apps/gogs/gogs-0.12.1.ebuild: line 515: Ebuild contains leading spaces
www-apps/gogs/gogs-0.12.1.ebuild: line 516: Ebuild contains leading spaces
www-apps/gogs/gogs-0.12.1.ebuild: line 517: Ebuild contains leading spaces

Use tabs instead please

[Comment 3 Reva Denis 2020-09-11 16:11:06 UTC]

Bumped in dev with intendation fixes.
Also fixed systemd, thank you for attention. Ebuild where I taked systemd part use own custom functions to set dependencies, so I has just remove it.

[Comment 4 Andrew Nowa Ammerlaan 2020-09-11 17:06:16 UTC]

Awesome merged it to master

[Comment 5 Larry the Git Cow 2021-01-10 11:31:56 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=ed515cf2a9eae78e2d1d6f8881e49a427b4d0942

commit ed515cf2a9eae78e2d1d6f8881e49a427b4d0942
Author:     Theo Anderson <[e-mail]>
AuthorDate: 2021-01-08 11:17:28 +0000
Commit:     Theo Anderson <[e-mail]>
CommitDate: 2021-01-08 11:17:28 +0000

    www-apps/gogs: tidy ebuild
    
    Closes: https://bugs.gentoo.org/741522
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Theo Anderson <[e-mail]>

 www-apps/gogs/files/gogs-0.12.3.patch |  6 ++---
 www-apps/gogs/gogs-0.12.3.ebuild      | 45 +++++++++++++++++++----------------
 2 files changed, 28 insertions(+), 23 deletions(-)