Bug 740778

Summary:	net-misc/oidc-agent-3.3.1 does not respect LDFLAGS for oidc-token and liboidc-agent.so
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Marek Szuba <marecki>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2020-09-07 06:05:55 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/oidc-agent-3.3.1 does not respect LDFLAGS.
Discovered on: amd64 (internal ref: tinderbox)

NOTE:
To reproduce this issue you may want to set LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ context you may want to see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect LDFLAGS.

Comment 1 Agostino Sarubbo gentoo-dev

2020-09-07 06:05:57 UTC

Created attachment 658868 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2020-09-07 14:36:20 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=141f1b5254fdbb263ba1d3a5697da791f359ffc7

commit 141f1b5254fdbb263ba1d3a5697da791f359ffc7
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-09-07 14:30:53 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-09-07 14:36:12 +0000

    net-misc/oidc-agent: fix LDFLAGS propagation
    
    Upstream uses three different sets of linker flags: one for
    liboidc-agent.so (declared inline), one for oidc-token (CLIENT_LFLAGS)
    and one for everything else (LFLAGS). The previous version of the
    toolchain patch only injected LDFLAGS into the latter, hence QA warnings
    for the former two.
    
    Closes: https://bugs.gentoo.org/740778
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 .../oidc-agent-3.3.1_makefile-toolchain-vars.patch     | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)