Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 740250

Summary: games-emulation/pcsx2-9999 - add support for native amd64
Product: Gentoo Linux Reporter: Ionen Wolkens <ionen>
Component: Current packagesAssignee: nE0sIghT <ykonotopov>
Status: RESOLVED FIXED    
Severity: normal CC: O01eg, proxy-maint
Priority: Normal Keywords: PATCH, PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/18931
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: remove multilib patch
0001-games-emulation-pcsx2-support-native-64bit-build.patch

Description Ionen Wolkens gentoo-dev 2020-09-03 20:56:55 UTC
Created attachment 658214 [details, diff]
remove multilib patch

Support for 64bit builds was finally added upstream, adding here would be nice to save users from multilib nonsense on amd64.

I personally don't see this as urgent so it could wait for support to mature if need be, no telling if game/plugins compatibility is intact.

I did manage to build it with included test patch (with current HEAD at b633b2a2d1d87bb92857add69863c45b03b4fb4a) which removes usage of multilib entirely. Other things can probably be cleaned up (there is some QA notices too) but I kept it minimal just for testing, did not check if x86 native build still works with the patch.

=pcsx2-1.6.0 does not have support for this, so limited to -9999 for now.

$ file /usr/bin/PCSX2 
/usr/bin/PCSX2: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 5.4.0, stripped

Loading plugins from /usr/lib64/pcsx2...
	Bound   GS: libGSdx.so [GSdx 64-bit (GCC 9.3.0 AVX/AVX) 1.2.0]
Comment 1 nE0sIghT 2020-09-05 11:50:26 UTC
It doesn't merged yet as I see: https://github.com/PCSX2/pcsx2/pull/3451
Comment 2 Ionen Wolkens gentoo-dev 2020-10-17 00:07:10 UTC
(In reply to nE0sIghT from comment #1)
> It doesn't merged yet as I see: https://github.com/PCSX2/pcsx2/pull/3451
I don't think that PR was still relevant, a newer comment in it notably explains:
> The changes for the x64 port have been merged into master.
> So, basically, we are done here. The port seems to be stable.
Comment 3 nE0sIghT 2020-10-17 08:59:42 UTC
A few issues should be resolved before moving forward:
64bit memcard portability: https://github.com/PCSX2/pcsx2/issues/3839
libfmt build fix (arch-independend): https://github.com/PCSX2/pcsx2/pull/3838
Comment 4 Ionen Wolkens gentoo-dev 2020-10-23 00:16:42 UTC
(In reply to nE0sIghT from comment #3)
> 64bit memcard portability: https://github.com/PCSX2/pcsx2/issues/3839
Reading recent comments in it does make it sound it'd be best to wait a while even for the live ebuild (or whenever you feel it's ready).

Thanks for the reviewing and checking with upstream.
Comment 5 Ionen Wolkens gentoo-dev 2020-11-12 22:50:07 UTC
Created attachment 671185 [details, diff]
0001-games-emulation-pcsx2-support-native-64bit-build.patch

Rebase against 4a5a35dbff21c977c55b60b2137aaf793055a5fa
Comment 6 Larry the Git Cow gentoo-dev 2021-01-15 08:44:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2fb6595fb15e93b8c04a59034a27d517fcde3030

commit 2fb6595fb15e93b8c04a59034a27d517fcde3030
Author:     Yuri Konotopov <ykonotopov@gnome.org>
AuthorDate: 2021-01-08 11:07:20 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-15 08:44:37 +0000

    games-emulation/pcsx2: switch to native build on amd64
    
    Closes: https://bugs.gentoo.org/740250
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Yuri Konotopov <ykonotopov@gnome.org>
    Co-authored-by: Ionen Wolkens <sudinave@gmail.com>
    Signed-off-by: Ionen Wolkens <sudinave@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/18931
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 games-emulation/pcsx2/pcsx2-9999.ebuild | 51 ++++++++++++++-------------------
 1 file changed, 21 insertions(+), 30 deletions(-)