Bug 73986

Summary:	gcc-config fails to fail on bad profiles.
Product:	Gentoo Linux	Reporter:	Tres 'RiverRat' Melton <RiverRat>
Component:	[OLD] GCC Porting	Assignee:	Gentoo Toolchain Maintainers <toolchain>
Status:	RESOLVED WORKSFORME
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Fix

Description Tres 'RiverRat' Melton 2004-12-10 01:35:03 UTC

I did search for a similiar bug before posting but didn't find one.
I can't imagine anyone wanting to run:

"gcc-config i686-pc-linux-gnu-3.3.4-bogus-config" 

but if there is a reason please tell me and I'll go away.  This might be the case as gcc-config thinks about it on line 467 but decides not to fail (the exit command is commented out).  I have added a check to ensure that the new profile does in fact exist and is readable before doing anything else.  Without this patch gcc-config spits out three errors and then indicates success.

Reproducible: Always
Steps to Reproduce:
1.  run gcc-config with a bogus profile name.
2.
3.

Actual Results:  
gcc-config spits out three errors, then indicates success.

Expected Results:  
An error mesage and exit.

Comment 1 Tres 'RiverRat' Melton 2004-12-10 01:49:04 UTC

Created attachment 45666 [details, diff]
Fix

This patch makes gcc-config fail if there is no config file for the named
profile.

Comment 2 SpanKY gentoo-dev

2004-12-10 07:46:01 UTC

i assume this is against 1.3.6 because 1.3.7 handles non-existant profiles correctly

1.3.7 should be going into stable soon