Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 739770

Summary: media-plugins/vdr-xineliboutput-2.2.0-r3 - add wayland support
Product: Gentoo Linux Reporter: Christian Kunkel <ch.kunkel>
Component: Current packagesAssignee: Gentoo VDR Project <vdr>
Status: IN_PROGRESS ---    
Severity: normal Keywords: EBUILD
Priority: Normal    
Version: unspecified   
Hardware: AMD64   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=739760
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: vdr-xineliboutput-2.2.0-r3.ebuild
vdr-xineliboutput-2.2.0-r3.ebuild

Description Christian Kunkel 2020-08-31 18:16:46 UTC
Created attachment 657650 [details]
vdr-xineliboutput-2.2.0-r3.ebuild

IUSE wayland added and ebuild modificated.
The wayland frontend vdr-wlfe is only available if you have installed 
xine-lib-1.2.10 with the wayland flag.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-01 07:20:02 UTC
Comment on attachment 657650 [details]
vdr-xineliboutput-2.2.0-r3.ebuild

--- vdr-xineliboutput-2.2.0-r2.ebuild
+++ vdr-xineliboutput-2.2.0-r3.ebuild
@@ -14,7 +14,7 @@
 SLOT="0"
 LICENSE="GPL-2+"
 KEYWORDS="~amd64 ~x86"
-IUSE="bluray caps cec dbus fbcon jpeg libextractor nls opengl +vdr vaapi vdpau +X +xine xinerama"
+IUSE="bluray caps cec dbus fbcon jpeg libextractor nls opengl +vdr vaapi vdpau wayland +X +xine xinerama"

 COMMON_DEPEND="
        vdr? (
@@ -81,6 +81,10 @@
                myconf="${myconf} --disable-libavutil"
        fi

+       if use wayland && has_version ">=media-libs/xine-lib-1.2.10[wayland]"; then
+               myconf="${myconf} --enable-wayland"
+       fi
+

That is an "automagical" dependency; you should use a USE dependency instead:

[R|]DEPEND="
        >=media-libs/xine-lib-1.2.10[wayland?]
        [...]
"

        # No autotools based configure script
        ./configure \
                --cc=$(tc-getCC) \
@@ -139,6 +143,13 @@
                                doins libxineliboutput-fbfe.so.*
                        fi

+                       if use wayland && has_version ">=media-libs/xine-lib-1.2.10[wayland]"; then

Same as above.

@@ -152,3 +163,12 @@
                dodoc HISTORY README
        fi
 }
+
+pkg_postinst() {
+       if use wayland && ! has_version ">=media-libs/xine-lib-1.2.10[wayland]"; then
+               elog "You have selcted the native wayland frontend. The wayland frontend"

"selcted"

+               elog "vdr-wlfe is only available if you have installed >= xine-lib-1.2.10"
+               elog "with the wayland flag."
+        fi

The entire conditional would be unneeded if you used a USE dependency as described above.

+}
+

No need for that whitespace at the end.
Comment 2 Christian Kunkel 2020-09-23 14:10:06 UTC
Created attachment 662116 [details]
vdr-xineliboutput-2.2.0-r3.ebuild

Modified ebuild.