Summary: | media-video/vlc-3.0.11.1 fails to build with net-libs/libupnp-1.14.0 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Xavier Miller (RETIRED) <xaviermiller> |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | benjamin.reveille, sam, thev00d00, whissi |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 727170 | ||
Attachments: |
build.log
libupnp-1.14.0-compatibility.patch version 2 of the patch from comment 3 |
Description
Xavier Miller (RETIRED)
![]() [ebuild R ] net-libs/libupnp-1.14.0::gentoo USE="reuseaddr -blocking-tcp -debug -doc -ipv6 -samples -static-libs" 0 KiB [ebuild R ] media-video/vlc-3.0.11.1:0/5-9::gentoo USE="X a52 alsa cddb dbus dts dvbpsi dvd encode ffmpeg flac fluidsynth gcrypt gnome-keyring jack jpeg libnotify libsamplerate lua mad matroska mp3 mpeg mtp ncurses ogg opus png qt5 ssl svg truetype udev upnp v4l vaapi vorbis x264 xml -aom -archive -aribsub -bidi -bluray -chromaprint -chromecast -dav1d -dc1394 -debug (-directx) -faad -fdk -fontconfig -gme -gstreamer -ieee1394 -kate -libass -libcaca -libtar -libtiger -linsys -lirc -live -macosx-notifications -modplug -musepack -nfs -omxil -optimisememory -projectm -pulseaudio -rdp -run-as-root -samba -sdl-image -sftp -shout -sid -skins -soxr -speex -srt -taglib -test -theora -tremor -twolame -vdpau -vnc -vpx -wayland -x265 -zeroconf -zvbi" CPU_FLAGS_X86="mmx sse" 0 KiB Created attachment 657182 [details]
build.log
Created attachment 657452 [details, diff] libupnp-1.14.0-compatibility.patch Caused by https://github.com/pupnp/pupnp/commit/7b3f0f5f497f9f493c82307af495b87fa9ebdacb Are you actually using UPnP? Can you test the attached patch? Proposed patch from Comment 3 fails: " services_discovery/upnp.cpp: Dans la fonction membre statique ��static UpnpInstanceWrapper* UpnpInstanceWrapper::get(vlc_object_t*, services_discovery_t*)��: services_discovery/upnp.cpp:1705:26: erreur: ��getPreferedAdapter�� n'a pas �t� d�clar� dans cette port�e 1705 | psz_miface = getPreferedAdapter(); | ^~~~~~~~~~~~~~~~~~ " I'm guessing getPreferedAdapter is declared behind another #ifdef UPNP_ENABLE_IPV6 Created attachment 657456 [details, diff] version 2 of the patch from comment 3 With this new patch It compiles and plyaing my upnpn shares from vlc works (although in IPV4)... Maybe a simpler solution would be to "-D UPNP_ENABLE_IP6" on configure... (In reply to Benjamin Réveillé from comment #5) > Created attachment 657456 [details, diff] [details, diff] > version 2 of the patch from comment 3 > > With this new patch It compiles and plyaing my upnpn shares from vlc works > (although in IPV4)... > > Maybe a simpler solution would be to "-D UPNP_ENABLE_IP6" on configure... This patch works for me, thanks! The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=878c4f43fd879486e23ebfa1d071441124f109f3 commit 878c4f43fd879486e23ebfa1d071441124f109f3 Author: Thomas Deutschmann <whissi@gentoo.org> AuthorDate: 2020-08-30 15:21:07 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2020-08-30 15:21:07 +0000 media-video/vlc: force net-libs/libupnp[ipv6] for USE=upnp Closes: https://bugs.gentoo.org/739320 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> media-video/vlc/vlc-3.0.11.1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I have a -ipv6 system. Am I forced to enable ipv6 in order to have upnp working? For this package, yes -- shouldn't be a big deal, is it? *I* am not going to patch VLC. At some point I hope upstream will fix but I am also not going to report upstream due to their registration requirement. OK I accept this workaround ;) |