Bug 739040

Summary:	sys-auth/yubico-piv-tool-2.1.1 fails to compile
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	remy
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log 1-CMakeError.log 1-CMakeOutput.log

Description Agostino Sarubbo gentoo-dev

2020-08-26 05:17:42 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-auth/yubico-piv-tool-2.1.1 fails to compile.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GLIBC-2.32. If you think that this issue is strictly related to GLIBC please block bug 736174.

Comment 1 Agostino Sarubbo gentoo-dev

2020-08-26 05:17:44 UTC

Created attachment 656782 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2020-08-26 05:17:45 UTC

Created attachment 656784 [details]
1-CMakeError.log

1-CMakeError.log

Comment 3 Agostino Sarubbo gentoo-dev

2020-08-26 05:17:46 UTC

Created attachment 656786 [details]
1-CMakeOutput.log

1-CMakeOutput.log

Comment 4 Remy Blank 2020-08-29 08:10:13 UTC

This seems to be due to a missing dependency on dev-libs/check. I get the same error on a machine that doesn't have it installed, and emerging it allows sys-auth/yubico-piv-tool-2.1.1 to install successfully.

The ebuild lists dev-libs/check as a dependency conditional on the "test" USE flag. Maybe it should be made unconditional?

Comment 5 Larry the Git Cow gentoo-dev

2020-09-06 20:27:24 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=022da5ba99be2b208ba8ae6ba60c15b118bbac5f

commit 022da5ba99be2b208ba8ae6ba60c15b118bbac5f
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-09-06 20:23:13 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-09-06 20:27:09 +0000

    sys-auth/yubico-piv-tool: only build tests when FEATURES=test is set
    
    This means we no longer need dev-libs/check present even when one does
    not wish to run the test suite.
    
    Closes: https://bugs.gentoo.org/739040
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 .../yubico-piv-tool-2.1.1-tests-optional.patch     | 39 ++++++++++++++++++++++
 .../yubico-piv-tool/yubico-piv-tool-2.1.1.ebuild   |  6 +++-
 2 files changed, 44 insertions(+), 1 deletion(-)