Summary: | sys-devel/patch-2.7.6-r4 tests fail with "1: eval: Bad substitution" with app-shells/dash | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Paolo Pedroni <paolo.pedroni> |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kfm, sam |
Priority: | Normal | Keywords: | PATCH, TESTFAILURE, UPSTREAM |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://git.savannah.gnu.org/cgit/patch.git/commit/?id=7623b2dc0d1837ecfd58f32efc78e35834deeb38 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 526268 | ||
Attachments: |
patch-2.7.6-r4:20200824-112308.log.gz
patch-2.7.6-fix-test-suite-further.patch |
Description
Paolo Pedroni
2020-08-24 11:39:12 UTC
Created attachment 680791 [details, diff]
patch-2.7.6-fix-test-suite-further.patch
Here is a patch that is supplemental to the existing "fix-test-suite" patch. It is also eligible for upstream but the instance here is intended to apply cleanly for the current ebuild.
Committed upstream: https://git.savannah.gnu.org/cgit/patch.git/commit/?id=7623b2dc0d1837ecfd58f32efc78e35834deeb38. ping. can someone apply the patch? Is this really important enough to warrant a backport? Anyway, if the patch works, feel free to commit it. (In reply to Mike Gilbert from comment #4) > Is this really important enough to warrant a backport? This is one of those things I'd prefer not to bother anybody about but would still like fixed, so it's hard to get the balance right. I don't really like nagging about this sort of thing either. Thanks for putting up with it. Point taken, although my view is that if we have a patch, we may as well use it - especially because it just makes life easier if we have to stable a revision before the next release (I use dash most of the time when doing arch testing now). (In reply to Mike Gilbert from comment #5) > Anyway, if the patch works, feel free to commit it. Thanks! It was important enough for (In reply to Mike Gilbert from comment #4) > Is this really important enough to warrant a backport? Apparently, it was important enough for commit ff5c047 to have occurred. By what metric would it be less important now than it was then? (In reply to Kerin Millar from comment #7) > Apparently, it was important enough for commit ff5c047 to have occurred. By > what metric would it be less important now than it was then? Previous commit fixed a problem you will experience when running Gentoo out of the box. To experience the reported bug you would have to switch default shell... Anyway, I'll take care of it. (In reply to Thomas Deutschmann from comment #8) > Previous commit fixed a problem you will experience when running Gentoo out > of the box. To experience the reported bug you would have to switch default > shell... That's a compelling answer. > Anyway, I'll take care of it. Thanks. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c02ca61191198aacf2bd51c4d5a7b53b1cbb5ab9 commit c02ca61191198aacf2bd51c4d5a7b53b1cbb5ab9 Author: Thomas Deutschmann <whissi@gentoo.org> AuthorDate: 2021-04-29 22:20:43 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2021-04-29 22:21:08 +0000 sys-devel/patch: fix test suite when using dash Closes: https://bugs.gentoo.org/738810 Package-Manager: Portage-3.0.18, Repoman-3.0.3 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> .../patch/files/patch-2.7.6-fix-test-suite.patch | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) Just to further explain my reaction: We are talking about an issue that only affects the test suite, and only when the system shell is dash. These 2 things together will affect a miniscule number of users, and there are a couple of very simple/obvious workarounds. Anyway, it was sort of a grumpy response, so apologies to all. (In reply to Mike Gilbert from comment #11) > Just to further explain my reaction: We are talking about an issue that only > affects the test suite, and only when the system shell is dash. These 2 > things together will affect a miniscule number of users, and there are a > couple of very simple/obvious workarounds. > > Anyway, it was sort of a grumpy response, so apologies to all. Not to worry. It was a pertinent question, the motivation for which was rendered clear to me by reading Thomas' comment. All's well that ends well, as the saying goes. |