| Summary: | media-sound/milkytracker-1.02.00-r1 build fails (SDL2MAIN_LIBRARY not set) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Vladimir Vrzić <vvrzic> |
| Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fordfrog |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 736186 | ||
| Bug Blocks: | |||
| Attachments: |
Since we are building on Linux, SDL2main is not required, we can set SDL2MAIN_LIBRARY to an empty string
build log emerge --info output |
||
It would help to see the full build.log and emerge --info. Created attachment 655238 [details]
build log
media-sound/milkytracker-1.02.00-r1 failed build log
Created attachment 655240 [details]
emerge --info output
Sure thing. Attached. works fine for me with media-libs/libsdl2-2.0.12-r1:0 so is it really necessary to drop it from milkytracker? once 2.0.12-r1 is stabilized, the old will be dropped and the issue should be resolved. also, is there any reason for using libsdl2 2.0.10 when you are on amd64 and it's already stable there? # equery meta libsdl2 * media-libs/libsdl2 [gentoo] Maintainer: games@gentoo.org (Gentoo Games Project) Upstream: None specified Homepage: https://www.libsdl.org/ Location: /usr/portage/media-libs/libsdl2 Keywords: 2.0.10-r1:0: arm64 ppc ppc64 Keywords: 2.0.12-r1:0: amd64 arm sparc x86 ~alpha ~arm64 ~hppa ~ia64 ~ppc ~ppc64 License: ZLIB I am using media-libs/libsdl2-2.0.12-r1. Not sure why CMake says it detected "2.0.10". (In reply to Vladimir Vrzić from comment #6) > I am using media-libs/libsdl2-2.0.12-r1. Not sure why CMake says it detected > "2.0.10". could you please re-emerge libsdl2 and then milkytracker? Ah, now I see why. I posted this bug report and patch on 2020-08-17. At that time the stable version on amd64 was media-libs/libsdl2-2.0.10-r1. media-libs/libsdl2-2.0.12-r1 was marked stable on amd64 a day later, on 2020-08-18 -- https://packages.gentoo.org/packages/media-libs/libsdl2/changelog Today (2020-08-20), with media-libs/libsdl2-2.0.12-r1 installed, media-sound/milkytracker-1.02.00-r1 builds cleanly without the patch. thank you for reporting this back. so the issue is related only to libsdl2-2.0.10 and once 2.0.12-r1 is stabilized on the remaining arches, this issue should be resolved. i will keep it open till then. Sounds like a plan. Thanks for checking on your end with the new version of libsdl2! Actually since media-sound/milkytracker is not stable you can already declare this as fixed by 2.0.12-r1. (In reply to Andreas Sturmlechner from comment #11) > Actually since media-sound/milkytracker is not stable you can already > declare this as fixed by 2.0.12-r1. i'm keeping it because there is still a chance somenone might to compile it against libsdl-2.0.10-r1 which is still in the tree. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=986dc0cd77afb7ea01afee0e32d80afa4fe4719a commit 986dc0cd77afb7ea01afee0e32d80afa4fe4719a Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2020-09-08 08:02:28 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2020-09-08 08:02:28 +0000 media-libs/libsdl2: removed obsolete 2.0.10-r1 Closes: https://bugs.gentoo.org/737606 Package-Manager: Portage-3.0.6, Repoman-3.0.1 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-libs/libsdl2/Manifest | 1 - .../libsdl2/files/libsdl2-2.0.10-static-libs.patch | 44 ----- media-libs/libsdl2/libsdl2-2.0.10-r1.ebuild | 189 --------------------- 3 files changed, 234 deletions(-) |
Created attachment 655062 [details, diff] Since we are building on Linux, SDL2main is not required, we can set SDL2MAIN_LIBRARY to an empty string Build fails with the following message: CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: SDL2MAIN_LIBRARY linked by target "milkyplay" in directory /var/tmp/portage/media-sound/milkytracker-1.02.00-r1/work/MilkyTracker-1.02.00/src/milkyplay linked by target "osinterface" in directory /var/tmp/portage/media-sound/milkytracker-1.02.00-r1/work/MilkyTracker-1.02.00/src/ppui/osinterface Solution: Since we are building on Linux, SDL2main is not required. We can set SDL2MAIN_LIBRARY to an empty string. Patch is attached.