Bug 737060

Summary:	dev-lang/lazarus-2.2.4 does not respect CFLAGS/LDFLAGS
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Amy Liffey <amynka>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, proxy-maint, voron1
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/28789
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	59506, 331933
Attachments:	build.log.xz

Description Agostino Sarubbo gentoo-dev

2020-08-14 06:50:07 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-lang/lazarus-2.0.6 does not respect CFLAGS/LDFLAGS.
Discovered on: amd64 (internal ref: tinderbox)

NOTE:
To reproduce this issue you may want to add "-frecord-gcc-switches" to CFLAGS/CXXFLAGS/FFLAGS/FCFLAGS and LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect CFLAGS/LDFLAGS.

Comment 1 Agostino Sarubbo gentoo-dev

2020-08-14 06:50:09 UTC

Created attachment 654548 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

Comment 2 Agostino Sarubbo gentoo-dev

2021-10-14 14:45:22 UTC

ci has reproduced this issue with version 2.0.12 - Updating summary.

Comment 3 Agostino Sarubbo gentoo-dev

2022-02-02 16:10:16 UTC

ci has reproduced this issue with version 2.2.0 - Updating summary.

Comment 4 Agostino Sarubbo gentoo-dev

2022-12-12 19:30:36 UTC

ci has reproduced this issue with version 2.2.4 - Updating summary.

Comment 5 Larry the Git Cow gentoo-dev

2023-01-11 09:41:14 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc4ae6502bc01de42621d6744ebca15b882de5fd

commit dc4ae6502bc01de42621d6744ebca15b882de5fd
Author:     Michael Corvinus <voron1@gmail.com>
AuthorDate: 2022-12-24 21:31:42 +0000
Commit:     Amy Liffey <amynka@gentoo.org>
CommitDate: 2023-01-11 09:40:50 +0000

    dev-lang/lazarus: fix calling `gcc` directly
    
    The build system does things like GCCLIBDIR:=$(shell dirname `gcc -m32 -print-libgcc-file-name`)
    Replace with ${CC}.
    
    Add QA_FLAGS_IGNORED and QA_PRESTRIPPED as FPC doesn't care about CFLAGS and does its own stripping.
    
    Closes: https://bugs.gentoo.org/818154
    Closes: https://bugs.gentoo.org/737060
    
    Signed-off-by: Michael Corvinus <voron1@gmail.com>
    Signed-off-by: Amy Liffey <amynka@gentoo.org>

 dev-lang/lazarus/Manifest                           |  1 +
 ...lazarus-2.2.4.ebuild => lazarus-2.2.4-r1.ebuild} | 21 ++++++++++++++++++---
 2 files changed, 19 insertions(+), 3 deletions(-)