Bug 736972

Summary:	x11-terms/terminator should conditionally depend on dev-libs/keybinder
Product:	Gentoo Linux	Reporter:	Yaroslav Isakov <yaroslav.isakov>
Component:	Current packages	Assignee:	Alexey <alexey+gentoo>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alexey+gentoo, jstein, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/17117
Whiteboard:
Package list:		Runtime testing required:	---

Description Yaroslav Isakov 2020-08-13 11:51:49 UTC

Right now terminator depends on keybinder, but it is needed only if display_manager() == 'X11'. Even if display manager is X11, and keybinder cannot be loaded, "hide_window shortcut will be unavailable". So, I think that it would be best to make this dep optional. Otherwise, it will introduce X11 library in Wayland-only system.

Comment 1 Larry the Git Cow gentoo-dev

2020-08-31 02:47:06 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4e3656e991694d5c401112513da593f519d79968

commit 4e3656e991694d5c401112513da593f519d79968
Author:     Alexey Sokolov <sokolov@google.com>
AuthorDate: 2020-08-13 22:45:19 +0000
Commit:     Stefan Strogin <steils@gentoo.org>
CommitDate: 2020-08-31 02:42:18 +0000

    x11-terms/terminator: move keybinder behind X USE flag
    
    Closes: https://bugs.gentoo.org/736972
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Closes: https://github.com/gentoo/gentoo/pull/17117
    Signed-off-by: Stefan Strogin <steils@gentoo.org>

 x11-terms/terminator/terminator-1.92-r2.ebuild | 60 ++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

Comment 2 Alexey 2020-10-15 10:46:58 UTC

FTR, keybinder is moving from X USE flag to optfeature: https://github.com/gentoo/gentoo/pull/17830