Summary: | gentoo-dev-sources patches for amd64 compaq R3000 series and alps touchpad driver | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Mike Doty (RETIRED) <kingtaco> |
Component: | [OLD] Unspecified | Assignee: | Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel> |
Status: | VERIFIED UPSTREAM | ||
Severity: | enhancement | Keywords: | Inclusion |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
cardbus patch
alps patch |
Description
Mike Doty (RETIRED)
2004-12-05 14:38:14 UTC
Created attachment 45344 [details, diff]
cardbus patch
cardbus patch
Created attachment 45345 [details, diff]
alps patch
alps patch
Greg, how do these look to you? Neither are in 2.6.10 tree Ick, I say no to both of them. No to the cardbus patch, as it touch core pci code that all arches run (why is this patch needed? Why isn't it submitted to the main kernel.org people?) And no to the alps patch, as it too hasn't been submitted to kernel.org, and we don't want to have to maintain it in our tree on our own. Please get the author to submit these patches upstream, and then Gentoo will pick them up. What do we tell people who have R3000 laptops? As I understand it, these patches are needed for a working system. Am I to tell them that they need to manualy patch their kernel? Many users wouldn't feel very comfortable with that. @gregkh: I don't understand your "why isn't this sent to kernel.org" comment. Do all patches need to be applied upstream before we use them? please advise. How many users have R3000 laptops? How many users have been hit by the pci core patch? How can you verify that this pci core patch does not mess up anyone else (hint, I think it will...) And yes, it is our policy that patches are submitted upstream before we apply them. It has been that way for quite some time. It reduces the effort we (the kernel team) have to spend resolving patches, it helps all users of Linux by being good members of the community, and it ensures that we get support from the upstream developers, which we need. I have an HP zv5000z (same as the R3000), and these patches came in handy for me... can't really speak for others. I can't imagine anyone having a problem with the alps patch... it's basically a clone of the synaptics patch already accepted into the kernel. The alps patch isn't bad, but it should be in upstream first. |