| Summary: | media-libs/giflib: use BDEPEND with EAPI 7 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | David Michael <fedora.dm0> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jsmolic, sam |
| Priority: | Normal | Keywords: | PATCH, PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/17358 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2452111c71da85ec84162847f57a42071238fda8 commit 2452111c71da85ec84162847f57a42071238fda8 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2020-10-19 19:14:34 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2020-10-19 19:14:34 +0000 media-libs/giflib: drop dependency on app-text/xmlto Closes: https://bugs.gentoo.org/734638 Signed-off-by: Mike Gilbert <floppym@gentoo.org> media-libs/giflib/giflib-5.2.1-r1.ebuild | 2 -- 1 file changed, 2 deletions(-) |
I tried cross-compiling giflib with USE=doc, and it wants to cross-compile xmlto due to the ebuild not using BDEPEND. Two issues: 1. The xmlto command needs to be executed natively in the doc subdirectory, so DEPEND needs to be changed to BDEPEND for that to work. 2. The release archive apparently includes the pregenerated documentation files, so the "emake -C doc" doesn't do anything. Unless users patch the source doc files, xmlto never runs in the first place. Reproducible: Always Steps to Reproduce: 1. emerge -v media-libs/giflib # with a sysroot profile Actual Results: It builds xmlto (and all its deps) in the sysroot. Expected Results: The xmlto command needs to be installed natively (if it runs at all). This fixes it. --- media-libs/giflib/giflib-5.2.1-r1.ebuild +++ media-libs/giflib/giflib-5.2.1-r1.ebuild @@ -14,7 +14,7 @@ KEYWORDS="~alpha amd64 arm arm64 hppa ~ia64 ~m68k ~mips ppc ppc64 s390 sparc x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris" IUSE="doc static-libs" -DEPEND="doc? ( app-text/xmlto )" +BDEPEND="doc? ( app-text/xmlto )" PATCHES=( "${FILESDIR}"/${PN}-5.1.9-gentoo.patch