Summary: | dev-lang/rust: compile error when CFLAGS_x86 is set to multiple arguments | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Matthew Dawson <matthew> |
Component: | Current packages | Assignee: | Gentoo Rust Project <rust> |
Status: | IN_PROGRESS --- | ||
Severity: | normal | CC: | herrtimson, navi, randy, rust |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/16846 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Matthew Dawson
2020-07-27 03:19:00 UTC
Pull request: https://github.com/gentoo/gentoo/pull/16846 thanks for reporting. I think we should get rid of env/cat thing completely. Not sure why it was done the way it is now. ok, the env trick was done because variables contain dashes.. to it's impossible to just export them. I will fix it a bit later. I don't like IFS solution and env solution. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0c6ec743ace5257046552f4d1745bbf46f2ed73c commit 0c6ec743ace5257046552f4d1745bbf46f2ed73c Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2020-07-31 08:01:57 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2020-07-31 09:20:33 +0000 dev-lang/rust: bump to 1.45.1 Bug: https://bugs.gentoo.org/734018 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> dev-lang/rust/Manifest | 1 + dev-lang/rust/rust-1.45.1.ebuild | 504 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 505 insertions(+) this bug has nothing to do with the ebuilds filtering out -mcpu -march and -mtune, doesn't it? (In reply to tt_1 from comment #5) > this bug has nothing to do with the ebuilds filtering out -mcpu -march and > -mtune, doesn't it? no, not at all. cross support filters out cpu specific flags. it needs to be smarter. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=51563211f1ddc9662e89cad5c1a2495fcdf9f117 commit 51563211f1ddc9662e89cad5c1a2495fcdf9f117 Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2020-10-08 19:32:12 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2020-10-09 06:23:05 +0000 dev-lang/rust: bump to 1.47.0 we now install to /usr/lib/rust/<ver> this is more robust and mirrors how rustup installs rust, also most slotted toolchain projects already to it, so we follow Bug: https://bugs.gentoo.org/734018 PR: https://github.com/gentoo/gentoo/pull/16846 Package-Manager: Portage-3.0.8, Repoman-3.0.1 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> dev-lang/rust/Manifest | 15 + ...46.0-don-t-create-prefix-at-time-of-check.patch | 31 ++ ....0-ignore-broken-and-non-applicable-tests.patch | 75 +++ dev-lang/rust/files/gentoo-musl-target-specs.patch | 168 ++++++ dev-lang/rust/rust-1.47.0.ebuild | 582 +++++++++++++++++++++ 5 files changed, 871 insertions(+) I've added IFS in a subshell, can you test rust-1.47.0 ? (In reply to Georgy Yakovlev from comment #8) > I've added IFS in a subshell, can you test rust-1.47.0 ? I've test compiled rust-1.47, and it worked. I didn't merge it as I needed to keep 1.46 to compile firefox. thanks for testing! firefox (at least latest) should compile fine now with 1.47.0, we have patches. but anyway, I do not recommend using 1.47.0 yet, revbumps with more fixes coming soon. so hold on to 1.46 for now. I will backport env fixes to stable versions. and sorry for taking so long, I lost track of the bug. (In reply to Georgy Yakovlev from comment #11) > and sorry for taking so long, I lost track of the bug. np, thanks for fixing it! |