Bug 733738 – [RAP] sys-apps/util-linux-2.36: compilation failure on prefix, error: 'O_PATH' undeclared

• Product: Gentoo Linux
• Status: CONFIRMED ---

[Description Guilherme Amadio 2020-07-24 06:32:04 UTC]

Created attachment 650444 [details]
build.log

On prefix-host, util-linux-2.36 fails to compile with the error shown below (full build log attached). I do not see this problem outside of prefix.

In file included from /tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/libmount/src/context_umount.c:22:
/tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/include/pathnames.h:61: warning: "_PATH_GSHADOW" redefined
 #define _PATH_GSHADOW  "/etc/gshadow"
 
In file included from /tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/include/pathnames.h:9,
                 from /tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/libmount/src/context_umount.c:22:
/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/usr/include/paths.h:47: note: this is the location of the previous definition
 #define _PATH_GSHADOW "/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/etc/gshadow"
 
In file included from /tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/libmount/src/context_umount.c:22:
/tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/include/pathnames.h:64: warning: "_PATH_SHELLS" redefined
 #define _PATH_SHELLS  "/etc/shells"
 
In file included from /tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/include/pathnames.h:9,
                 from /tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/libmount/src/context_umount.c:22:
/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/usr/include/paths.h:61: note: this is the location of the previous definition
 #define _PATH_SHELLS "/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/etc/shells"
 
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36 -include config.h -I/tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/include -DLOCALEDIR=\"/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/usr/share/locale\" -D_PATH_RUNSTATEDIR=\"/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/var/lib/run\" -D_PATH_SYSCONFSTATICDIR=\"/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/usr/lib\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fsigned-char -fno-common -Wall -Wextra -Wmissing-declarations -Wmissing-parameter-type -Wmissing-prototypes -Wno-missing-field-initializers -Wredundant-decls -Wsign-compare -Wtype-limits -Wuninitialized -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-parameter -Wunused-result -Wunused-variable -Wnested-externs -Wpointer-arith -Wstrict-prototypes -Wformat-security -Wimplicit-function-declaration -Wdiscarded-qualifiers -Werror=sequence-point -I./libblkid/src -I./libmount/src -I/tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/libmount/src -O2 -pipe -O2 -pipe -O2 -g -gdwarf -fno-omit-frame-pointer -c /tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/libmount/src/monitor.c  -fPIC -DPIC -o libmount/src/.libs/la-monitor.o
/tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/libmount/src/context_umount.c: In function 'lookup_umount_fs_by_statfs':
/tmp/portage/sys-apps/util-linux-2.36/work/util-linux-2.36/libmount/src/context_umount.c:294:18: error: 'O_PATH' undeclared (first use in this function)
   fd = open(tgt, O_PATH);
                  ^~~~~~

The extra warnings about redefinitions mean we may need some adjustments for util-linux in prefix to make sure that those macros point to the correct place.

Output of emerge --info:
Portage 3.0.0 (python 3.8.5-final-0, default/linux/amd64/17.0/no-multilib/prefix/kernel-2.6.32+, gcc-8.4.0, glibc-2.25-r11, 2.6.32-754.27.1.el6.x86_64 x86_64)
=================================================================
System uname: Linux-2.6.32-754.27.1.el6.x86_64-x86_64-Intel_Core_Processor_-Haswell,_no_TSX,_IBRS-with-glibc2.2.5
KiB Mem:     7492608 total,   2894292 free
KiB Swap:          0 total,         0 free
Head commit of repository amadio: d7a97f2fccec0596b16c9e48d3523ee3b57d519f

Head commit of repository gentoo: 71d6e42b423bcc4e755fa254a5878b4df3b5ef16

sh bash 5.0_p18
ld GNU ld (Gentoo 2.34 p4) 2.34.0
ccache version 3.7.11 [disabled]
app-shells/bash:          5.0_p18::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.30.3-r1::gentoo
dev-lang/python:          2.7.18-r1::gentoo, 3.5.7::gentoo, 3.6.11-r2::gentoo, 3.7.8-r2::gentoo, 3.8.5::gentoo, 3.9.0_beta5::gentoo
dev-util/ccache:          3.7.11::gentoo
dev-util/cmake:           3.18.0::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.69-r5::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.16.2::gentoo
sys-devel/binutils:       2.30-r3::gentoo, 2.31.1-r4::gentoo, 2.32-r1::gentoo, 2.33.1-r1::gentoo, 2.34-r1::gentoo
sys-devel/gcc:            4.9.4-r1::gentoo, 5.5.0::gentoo, 6.5.0-r3::gentoo, 7.5.0-r1::gentoo, 8.3.0-r3::gentoo, 8.4.0-r1::gentoo, 9.3.0-r1::gentoo, 10.2.0::gentoo
sys-devel/gcc-config:     2.3.1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.7::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r11::gentoo
Repositories:

amadio
    location: /cvmfs/sft.cern.ch/lcg/contrib/gentoo/portage/amadio
    sync-type: git
    sync-uri: https://github.com/amadio/gentoo-overlay.git
    masters: gentoo
    priority: 0
    sync-git-pull-extra-opts: --quiet

gentoo
    location: /cvmfs/sft.cern.ch/lcg/contrib/gentoo/portage/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo/gentoo.git
    priority: 1
    sync-git-pull-extra-opts: --quiet

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/etc /etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/etc/env.d /cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/etc/gentoo-release /etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -O2 -pipe"
DISTDIR="/tmp/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles force-prefix ipc-sandbox merge-sync multilib-strict network-sandbox parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sfperms strict unknown-features-warn unmerge-logs unmerge-orphans unprivileged"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j4 -l4"
PKGDIR="/tmp/portage/packages"
PORTAGE_CONFIGROOT="/cvmfs/sft.cern.ch/lcg/contrib/gentoo/linux/x86_64/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/tmp"
USE="X acl amd64 berkdb bzip2 cairo cli crypt cups dri fortran gdbm gif iconv ipv6 jpeg lapack libtirpc ncurses nptl old-kernel openmp pcre png prefix python readline seccomp split-usr sqlite ssl svg tcpd tiff truetype unicode xml zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext popcnt sse sse2 sse3 ssse3 sse4_1 sse4_2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_6 python3_7 python3_8" RUBY_TARGETS="ruby27 ruby26" USERLAND="GNU" VIDEO_CARDS="i915 i965 intel iris nouveau nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Benda Xu 2020-10-19 11:06:53 UTC]

Since 2.36, libmount unconditionally use O_PATH.

I think the right way moving forward is to disable mount on prefix.  But that will affect glib and should be done at once.

[Comment 2 Mike Gilbert 2020-10-19 14:22:26 UTC]

(In reply to Benda Xu from comment #1)
> I think the right way moving forward is to disable mount on prefix.

I'm not a prefix user, but I think it would make sense to disable it only for platforms that do not support O_PATH.

[Comment 3 Fabian Groffen 2021-01-24 12:33:42 UTC]

interesting, paths.h is provided by glibc.  Somerthing tells me util-linux does some detection of some sort and doesn't consider the fact of a glibc not provided by the host