Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 733428

Summary: The example for conditional eclass inheritance is outdated
Product: Documentation Reporter: Florian Schmaus <flow>
Component: DevmanualAssignee: Gentoo Devmanual Team <devmanual>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://devmanual.gentoo.org/general-concepts/portage-cache/index.html
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: 0001-portage-cache-use-a-contemporary-example-for-conditi.patch
0001-portage-cache-use-a-contemporary-example-for-conditi.patch

Description Florian Schmaus gentoo-dev 2020-07-21 14:25:37 UTC
The era of "-cvs" ebuilds is long gone (does anyone still remember those?). Instead devmanual should show a contemporary example for conditional eclass inheritance based on git live-ebuilds.

Reproducible: Always
Comment 1 Florian Schmaus gentoo-dev 2020-07-21 14:26:15 UTC
Created attachment 650080 [details, diff]
0001-portage-cache-use-a-contemporary-example-for-conditi.patch
Comment 2 Ulrich Müller gentoo-dev 2020-07-21 14:44:01 UTC
Note to self: Rewrap lines to < 80 chars when merging.
Comment 3 Florian Schmaus gentoo-dev 2020-07-21 14:47:38 UTC
Created attachment 650082 [details, diff]
0001-portage-cache-use-a-contemporary-example-for-conditi.patch

Updated patch with line wrap at 80 chars.
Comment 4 Larry the Git Cow gentoo-dev 2020-07-23 15:56:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=e26dd425b928996b0775ee3a01ef73e0edc2a6fb

commit e26dd425b928996b0775ee3a01ef73e0edc2a6fb
Author:     Florian Schmaus <flo@geekplace.eu>
AuthorDate: 2020-07-21 14:19:55 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2020-07-23 15:55:27 +0000

    general-concepts/portage-cache: Update example for conditional inherit
    
    The era of "-cvs" ebuilds is long gone (does anyone still remember
    those?). Instead devmanual should show a contemporary example for
    conditional eclass inheritance based on git live-ebuilds.
    
    Signed-off-by: Florian Schmaus <flo@geekplace.eu>
    [Slightly simplified example.]
    Closes: https://bugs.gentoo.org/733428
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 general-concepts/portage-cache/text.xml | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
Comment 5 Ulrich Müller gentoo-dev 2020-07-23 15:58:47 UTC
Merged, thank you for the patch.

I have slightly simplified the example: Assignment of S is specific for the devmanual ebuild. Also, we don't need all of these keywords.