Bug 733386

Summary:	games-simulation/openrct2 fails tests
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Conrad Kostecki <conikost>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/OpenRCT2/OpenRCT2/pull/12735
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log other.tar.bz2

Description Agostino Sarubbo gentoo-dev

2020-07-21 05:58:31 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-simulation/openrct2 fails tests.
Discovered on: amd64 (internal ref: ci)

Comment 1 Agostino Sarubbo gentoo-dev

2020-07-21 05:58:37 UTC

Created attachment 650044 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2020-07-21 05:58:40 UTC

Created attachment 650046 [details]
other.tar.bz2

other logs

Comment 3 Conrad Kostecki gentoo-dev

2020-07-21 17:35:10 UTC

I am unable to reproduce. All tests pass here.
Which version of gtest do you use?

Test project /var/tmp/portage/games-simulation/openrct2-0.2.6/work/openrct2-0.2.6_build
      Start  1: sawyercoding
      Start  2: languagepack
      Start  3: ini
      Start  4: platform
      Start  5: string
      Start  6: localisation
      Start  7: Crypt
      Start  8: ImageImporter
      Start  9: ride_ratings
 1/14 Test  #1: sawyercoding .....................   Passed    0.03 sec
      Start 10: multilaunch
      Start 11: tile_elements
      Start 12: replay_tests
      Start 13: pathfinding
      Start 14: s6importexporttests
 2/14 Test  #2: languagepack .....................   Passed    0.04 sec
 3/14 Test  #3: ini ..............................   Passed    0.04 sec
 4/14 Test  #4: platform .........................   Passed    0.04 sec
 5/14 Test  #5: string ...........................   Passed    0.03 sec
 6/14 Test  #6: localisation .....................   Passed    0.03 sec
 7/14 Test  #8: ImageImporter ....................   Passed    0.03 sec
 8/14 Test #12: replay_tests .....................   Passed    0.01 sec
 9/14 Test  #7: Crypt ............................   Passed    0.32 sec
10/14 Test #11: tile_elements ....................   Passed    0.39 sec
11/14 Test  #9: ride_ratings .....................   Passed    0.42 sec
12/14 Test #13: pathfinding ......................   Passed    0.66 sec
13/14 Test #10: multilaunch ......................   Passed    1.14 sec
14/14 Test #14: s6importexporttests ..............   Passed    2.04 sec

Comment 4 Agostino Sarubbo gentoo-dev

2020-07-22 10:47:04 UTC

(In reply to Conrad Kostecki from comment #3)
> I am unable to reproduce. All tests pass here.
> Which version of gtest do you use?

1.10.0_p20200702

Comment 5 Conrad Kostecki gentoo-dev

2020-08-19 21:04:27 UTC

It's related to gtest-1.10.0. I have a fix for that.

Comment 6 Larry the Git Cow gentoo-dev

2020-08-19 22:45:07 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54f89e0355173685f96ec3f67e0bf1a5773cad34

commit 54f89e0355173685f96ec3f67e0bf1a5773cad34
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2020-08-19 22:10:01 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-08-19 22:44:55 +0000

    games-simulation/openrct2: fix tests with newest gtest
    
    Closes: https://bugs.gentoo.org/733386
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../openrct2/files/openrct2-0.2.6-gtest-1.10.patch   | 20 ++++++++++++++++++++
 games-simulation/openrct2/openrct2-0.2.6.ebuild      |  1 +
 2 files changed, 21 insertions(+)