| Summary: | baselayout: various fixes in /lib/rcscripts/net.modules.d/helpers.d/{dhclient,udhcpc}-* | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Benoit Boissinot <benoit.boissinot> |
| Component: | [OLD] baselayout | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
correct the permissions of /lib/rcscripts/net.modules.d/helpers.d/{dhclient,udhcpc}-*
fixes typo in helpers.d/dhclient-ifconfig fix a typo in helpers.d/udhcpc-ifconfig |
||
Created attachment 45256 [details, diff]
correct the permissions of /lib/rcscripts/net.modules.d/helpers.d/{dhclient,udhcpc}-*
Created attachment 45266 [details, diff]
fixes typo in helpers.d/dhclient-ifconfig
fixe a trivial typo in dhclient-ifconfig
Created attachment 45267 [details, diff]
fix a typo in helpers.d/udhcpc-ifconfig
I think there is a typo in udhcpc-ifconfig (eth1 -> ${interface})
i added various fixes to helpers.d I've applied the dhlcient and udhcpc fixes to CVS I'll pester agriffis to modify the ebuild This seems like the better fix, no? (depending on if all helpers should
be executable ...)
-------------
Index: baselayout-1.11.7-r1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/sys-apps/baselayout/baselayout-1.11.7-r1.ebuild,v
retrieving revision 1.1
diff -u -r1.1 baselayout-1.11.7-r1.ebuild
--- baselayout-1.11.7-r1.ebuild 4 Dec 2004 07:14:14 -0000 1.1
+++ baselayout-1.11.7-r1.ebuild 4 Dec 2004 15:59:56 -0000
@@ -343,8 +343,8 @@
# problematic with CONFIG_PROTECT
insinto /lib/rcscripts/net.modules.d
doins ${S}/lib/rcscripts/net.modules.d/*
- insinto /lib/rcscripts/net.modules.d/helpers.d
- doins ${S}/lib/rcscripts/net.modules.d/helpers.d/*
+ exeinto /lib/rcscripts/net.modules.d/helpers.d
+ doexe ${S}/lib/rcscripts/net.modules.d/helpers.d/*
#
# Install baselayout documentation
there is no need for 'config-system' and 'functions' to be made executable (they are sourced). I don't know if that matters. regards, Benoit Fixed in baselayout-1.11.7-r2. Thanks for the patches! Btw, I just changed the ebuild to use cp -a instead of doins. The knowledge of the correct permissions is already in rc-scripts. There is no need to duplicate that knowledge to the baselayout ebuild |
The files in /lib/rcscripts/net.modules.d/helpers.d/{dhclient,udhcpc}-* should have the executable bit set. Without this, the net scripts doesn't work with dhclient. (permission denied). Reproducible: Always Steps to Reproduce: 1. emerge baselayout 2. /etc/init.d/net.eth0 restart 3. Actual Results: dhclient: execve (/lib/rcscripts/net.modules.d/helpers.d/dhclient-iproute2, ...): Permission denied arakou tonfa # emerge info Portage 2.0.51-r8 (default-linux/x86/2004.3, gcc-3.4.3, glibc-2.3.4.20041102-r0, 2.6.10-rc2-mm4-arakou i686) ================================================================= System uname: 2.6.10-rc2-mm4-arakou i686 AMD Athlon(TM) XP 2500+ Gentoo Base System version 1.6.7 Python: dev-lang/python-2.3.4 [2.3.4 (#1, Sep 8 2004, 15:27:57)] dev-lang/python: 2.3.4 sys-devel/autoconf: 2.59-r6, 2.13 sys-devel/automake: 1.8.5-r2, 1.5, 1.4_p6, 1.6.3, 1.7.9, 1.9.3 sys-devel/binutils: 2.15.92.0.2-r1 sys-devel/libtool: 1.5.10 virtual/os-headers: 2.6.8.1-r1 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CFLAGS="-O3 -march=athlon-xp -pipe -fomit-frame-pointer -ffast-math -mfpmath=sse -m3dnow -mmmx -msse" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/texmf/web2c /etc/env.d" CXXFLAGS="-O3 -march=athlon-xp -pipe -fomit-frame-pointer -ffast-math -mfpmath=sse -m3dnow -mmmx -msse" DISTDIR="/share/distfiles" FEATURES="autoaddcvs autoconfig buildsyspkg ccache distlocks gpg sandbox sfperms strict userpriv usersandbox" GENTOO_MIRRORS="ftp://bloby.residence.ens-lyon.fr ftp://alexis.residence.ens-lyon.fr/ ftp://sci7.residence.ens-lyon.fr ftp://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ ftp://ftp.easynet.nl/mirror/gentoo http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://sci7.residence.ens-lyon.fr/gentoo-portage" USE="3dnow X acpi alsa avi berkdb bitmap-fonts bonobo cdr crypt distcc dvd encode f77 fam flac foomaticdb fortran gdbm gif gtk gtk2 imagemagick imlib ipv6 jpeg libg++ libwww mad mikmod mmx mpeg ncurses nls nptl oggvorbis opengl pam pdflib perl png python quicktime radeon readline samba slang sse ssl svga tcpd tetex tiff truetype unicode vi x86 xine xml xml2 xv zlib"