Bug 732496

Summary:	xfce-base/libxfce4ui-{4.15.2,4.15.3-r1} should depend on x11-libs/gtk+[X]
Product:	Gentoo Linux	Reporter:	Niklaus 'vimja' Hofer <gentoo-bugzilla>
Component:	Current packages	Assignee:	XFCE Team <xfce>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dev, jstein, mgorny
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	emerge --info '=xfce-base/libxfce4ui-4.15.2::gentoo' emerge -pqv '=xfce-base/libxfce4ui-4.15.2::gentoo' build log

Description Niklaus 'vimja' Hofer 2020-07-13 18:39:19 UTC

When trying to build libxfce4ui-4.15 (I tried both 4.15.2 and 4.15.3) on a system that only has the `wayland` USE flag enabled but not `X`, compilation of the package fails. The reason is a missing header file. `gdk/gdkx.h` (`/usr/include/gtk-3.0/gdk/gdkx.h`) which is usually part of `x11-libs/gtk+`. However, this header file is not installed when `x11-libs/gtk+` is built with `-X`. The header is included through `/var/tmp/portage/xfce-base/libxfce4ui-4.15.3/work/libxfce4ui-4.15.3/libxfce4ui/xfce-sm-client.c`.

One solution is to make `libxfce4ui-4.15` depend on `x11-libs/gtk+[X]`. It's a shame though because it means one cannot build XFCE w/o X11 support :(

Comment 1 Niklaus 'vimja' Hofer 2020-07-13 18:40:08 UTC

Created attachment 649122 [details]
emerge --info '=xfce-base/libxfce4ui-4.15.2::gentoo'

Comment 2 Niklaus 'vimja' Hofer 2020-07-13 18:40:34 UTC

Created attachment 649124 [details]
emerge -pqv '=xfce-base/libxfce4ui-4.15.2::gentoo'

Comment 3 Niklaus 'vimja' Hofer 2020-07-13 18:41:37 UTC

Created attachment 649126 [details]
build log

Comment 4 Lara Maia 2021-09-11 15:49:04 UTC

the situation remains true for current versions of libxfce4ui on both stable and unstable. Trying to manually configure libxfce4ui to build without X support return the following:

$ ./configure --without-x
[...]
configure: error: X Window system libraries and header files are required

So I think a hard dependency on X is the way to go

Comment 5 Michał Górny archtester

2021-09-11 16:30:23 UTC

I'm sorry for missing this bug.

Comment 6 Larry the Git Cow gentoo-dev

2021-09-11 16:32:05 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d6921a23aff6dea634b2850ec4c97e07d76f4a4

commit 6d6921a23aff6dea634b2850ec4c97e07d76f4a4
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-09-11 16:31:43 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-09-11 16:31:43 +0000

    xfce-base/libxfce4ui: Require gtk+[X]
    
    Closes: https://bugs.gentoo.org/732496
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 xfce-base/libxfce4ui/libxfce4ui-4.16.0.ebuild | 2 +-
 xfce-base/libxfce4ui/libxfce4ui-4.16.1.ebuild | 2 +-
 xfce-base/libxfce4ui/libxfce4ui-4.17.0.ebuild | 2 +-
 xfce-base/libxfce4ui/libxfce4ui-4.17.1.ebuild | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)