Bug 732284 – sys-fs/extundelete-0.2.4-r1 fails to compile w/clang: extundelete.cc:1271:28: error: non-constant-expression cannot be narrowed from type 'int' to 'ext2_ino_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2020-07-11 19:37:06 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-fs/extundelete fails to compile.
Discovered on: amd64  (internal ref: tinderbox)

NOTE:
This machine uses a clang/LLVM toolchain.
If you think that this issue is strictly related to clang/LLVM please block bug 408963. If you think that this issue isstrictly related to the LLD linker, please block bug 731004.

[Comment 1 Agostino Sarubbo 2020-07-11 19:37:13 UTC]

Created attachment 648966 [details]
build.log

build log and emerge --info

[Comment 2 Richard H. 2021-09-23 10:01:35 UTC]

Deninitely only happens with CLang. I stumbled upon the same problem right now. GCC works fine.

[Comment 3 Stephan Hartmann (RETIRED) 2021-09-29 07:40:59 UTC]

Created attachment 741954 [details, diff]
clang patch

[Comment 4 Richard H. 2021-11-01 18:49:46 UTC]

(In reply to Stephan Hartmann from comment #3)
> Created attachment 741954 [details, diff] [details, diff]
> clang patch

I tried the patch via userpatches and it works fine again now. Thank you!

[Comment 5 Agostino Sarubbo 2022-01-25 14:24:28 UTC]

tinderbox has reproduced this issue with version 0.2.4-r1 - Updating summary.

[Comment 6 Larry the Git Cow 2022-04-05 03:41:18 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=067e25699b6489f41459d159976a8231a53f9a82

commit 067e25699b6489f41459d159976a8231a53f9a82
Author:     Stephan Hartmann <[e-mail]>
AuthorDate: 2022-04-05 03:39:52 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-04-05 03:40:26 +0000

    sys-fs/extundelete: swap Clang patch
    
    Closes: https://bugs.gentoo.org/732284
    Signed-off-by: Sam James <[e-mail]>

 sys-fs/extundelete/files/extundelete-0.2.4-clang.patch | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b1800e098380bf90979347622a1db4d6ad36677

commit 6b1800e098380bf90979347622a1db4d6ad36677
Author:     Denis Pronin <[e-mail]>
AuthorDate: 2022-03-19 10:13:32 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-04-05 03:37:32 +0000

    sys-fs/extundelete: fix build with clang
    
    patched src/extundelete.cc so that clang is not swearing on
    implicit narrowing
    
    Signed-off-by: Denis Pronin <[e-mail]>
    Bug: https://bugs.gentoo.org/732284
    Closes: https://github.com/gentoo/gentoo/pull/24658
    Signed-off-by: Sam James <[e-mail]>

 sys-fs/extundelete/extundelete-0.2.4-r1.ebuild         |  2 +-
 sys-fs/extundelete/files/extundelete-0.2.4-clang.patch | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

[Comment 7 Larry the Git Cow 2022-04-05 03:43:07 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fc46593ebca08e5c2489e5cb464ca9fc8322ddd5

commit fc46593ebca08e5c2489e5cb464ca9fc8322ddd5
Author:     Sam James <[e-mail]>
AuthorDate: 2022-04-05 03:42:37 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-04-05 03:42:56 +0000

    sys-fs/extundelete: apply clang patch in ~arch
    
    Just in case, given while it _shouldn't_ make a runtime difference,
    it could.
    
    Bug: https://bugs.gentoo.org/732284
    Signed-off-by: Sam James <[e-mail]>

 sys-fs/extundelete/extundelete-0.2.4-r1.ebuild |  7 ++-----
 sys-fs/extundelete/extundelete-0.2.4-r2.ebuild | 20 ++++++++++++++++++++
 2 files changed, 22 insertions(+), 5 deletions(-)