Bug 732114

Summary:	sys-apps/diffutils: EAPI 7 request
Product:	Gentoo Linux	Reporter:	David Michael <fedora.dm0>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PATCH
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=737502
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	diffutils-3.7-r1.ebuild

Description David Michael 2020-07-10 15:18:52 UTC

This is a simple package; can it be bumped to EAPI 7 to properly define gettext in BDEPEND?

The example patch drops xz like other ebuilds did since it's a base package, but if it needs to stay, it should also be in BDEPEND.

Reproducible: Always




--- a/sys-apps/diffutils/diffutils-3.7.ebuild
+++ b/sys-apps/diffutils/diffutils-3.7.ebuild
@@ -1,7 +1,7 @@
 # Copyright 1999-2020 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=6
+EAPI=7
 
 inherit flag-o-matic
 
@@ -15,8 +15,7 @@
 KEYWORDS="~alpha amd64 ~arm ~arm64 hppa ~ia64 ~m68k ~mips ppc ppc64 ~riscv ~s390 sparc ~x86 ~ppc-aix ~x64-cygwin ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~m68k-mint ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris"
 IUSE="nls static"
 
-DEPEND="app-arch/xz-utils
-	nls? ( sys-devel/gettext )"
+BDEPEND="nls? ( sys-devel/gettext )"
 
 DOCS=( AUTHORS ChangeLog NEWS README THANKS TODO )

Comment 1 Mike Gilbert gentoo-dev

2020-07-10 20:24:20 UTC

If you provide a patch produced using "git format-patch" I would be happy to apply it.

Comment 2 David Michael 2020-07-10 20:34:20 UTC

Created attachment 648836 [details, diff]
diffutils-3.7-r1.ebuild

I assumed you would want a revision bump for an EAPI change.

Comment 3 Larry the Git Cow gentoo-dev

2020-07-11 23:01:08 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aa159e51bb9c563de948887ab9311af1627db519

commit aa159e51bb9c563de948887ab9311af1627db519
Author:     David Michael <fedora.dm0@gmail.com>
AuthorDate: 2020-07-10 20:31:57 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-07-11 23:00:16 +0000

    sys-apps/diffutils: EAPI 7 bump
    
    Closes: https://bugs.gentoo.org/732114
    Package-Manager: Portage-2.3.99, Repoman-2.3.23
    Signed-off-by: David Michael <fedora.dm0@gmail.com>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-apps/diffutils/diffutils-3.7-r1.ebuild | 43 ++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)