Bug 732032

Summary:	sci-mathematics/gmp-ecm fails to compile
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Patrick Lauer <patrick>
Status:	RESOLVED FIXED
Severity:	normal	CC:	frp.bissey, sam
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/18007 https://github.com/gentoo/gentoo/pull/18044
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2020-07-10 08:05:51 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-mathematics/gmp-ecm fails to compile.
Discovered on: amd64  (internal ref: tinderbox)

NOTE:
This machine uses a clang/LLVM toolchain.
If you think that this issue is strictly related to clang/LLVM please block bug 408963. If you think that this issue isstrictly related to the LLD linker, please block bug 731004.

Comment 1 Agostino Sarubbo gentoo-dev

2020-07-10 08:05:56 UTC

Created attachment 648728 [details]
build.log

build log and emerge --info

Comment 2 François Bissey 2020-10-22 06:53:57 UTC

Error:
pm1fs2.c:1570:17: error: condition of OpenMP for loop must be a relational
      comparison ('<', '<=', '>', or '>=') of loop variable 'i'
    for (i = 0; (unsigned long) i <= 2 * deg - 2; i++)
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


this appears to be an openMP syntax issue that needs to be upstreamed.

Comment 3 François Bissey 2020-10-22 21:16:07 UTC

I am fairly sure I know how to fix this but I am waiting the blessing of upstream. Upstream home and bug tracker has moved to private gitlab instance. You need to be invited to be able to fill issues. Fortunately I have been in touch with the author before and I should receive my invite later today.

Comment 4 François Bissey 2020-10-23 08:45:16 UTC

?Upstream issue https://gitlab.inria.fr/zimmerma/ecm/-/issues/21857

Comment 5 François Bissey 2020-10-27 00:39:57 UTC

OK, new PR is correct now. The patch for gmp-ecm is merged upstream. I had a bit of back and forth with the author on Friday on the best thing to do.

Comment 6 Larry the Git Cow gentoo-dev

2021-01-22 04:31:01 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cafe8af137d1a9e2bfa62e9ebfb20df5cb6e2831

commit cafe8af137d1a9e2bfa62e9ebfb20df5cb6e2831
Author:     François Bissey <frp.bissey@gmail.com>
AuthorDate: 2020-10-27 00:32:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-22 04:28:24 +0000

    sci-mathematics/gmp-ecm: fix #732032, #750716 and update HOME and SRC_URI
    
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Closes: https://bugs.gentoo.org/732032
    Closes: https://bugs.gentoo.org/750716
    Signed-off-by: François René Pierre Bissey <frp.bissey@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/18044
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-mathematics/gmp-ecm/Manifest                   |  1 +
 .../gmp-ecm/files/gmp-ecm-7.0.4-openmp.patch       | 25 ++++++++++
 sci-mathematics/gmp-ecm/gmp-ecm-7.0.4-r3.ebuild    | 57 ++++++++++++++++++++++
 3 files changed, 83 insertions(+)