Bug 731302

Summary:	dev-ml/ocaml-gettext-0.3.7 - Error: This expression has type string but an expression was expected of type bytes
Product:	Gentoo Linux	Reporter:	Ian Pickworth <ian>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PATCH, PullRequest
Priority:	Normal
Version:	unspecified
Hardware:	AMD64
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/16964
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	737154
Attachments:	Patch to ConfMakefile.in Modify EAPI=5 ebuild src_prepare() to apply user patch build.log

Description Ian Pickworth 2020-07-07 17:38:38 UTC

Created attachment 648276 [details, diff]
Patch to ConfMakefile.in

In common with bugs 704102, 704108, 704956 and others, when dev-lang/ocaml is upgraded to the stable 4.09.0 version, dev-ml/ocaml-gettext-0.3.7 compile fails because of a change in the default use of -safe-strings.

To fix this, two patch files are needed, which are attached:
 - The unsafe_strings.patch adds the -unsafe-string option.
   To apply, it is placed in /etc/portage/patches//dev-ml/ocaml-gettext-0.3.7/unsafe_strings.patch

 - The ebuild change is needed because the ebuild is EAPI=5
   This is placed in /etc/portage/env/dev-ml/ocaml-gettext-0.3.7

With these two changes in place, dev-ml/ocaml-gettext-0.3.7 compiles successfully with warnings.

Comment 1 Ian Pickworth 2020-07-07 17:41:08 UTC

Created attachment 648278 [details, diff]
Modify EAPI=5 ebuild src_prepare() to apply user patch

Place this in /etc/portage/env/dev-ml/ocaml-gettext-0.3.7 to get ebuild to apply user patch

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2020-07-09 16:21:59 UTC

Could you please post a more descriptive error message, perhaps even the complete build log instead of a summary of part of a single line of output?

Comment 3 Ian Pickworth 2020-07-09 22:45:53 UTC

The "part of a single line of output" was the exact nub of the issue.
The other bugs mentioned have it in their titles as well.

I no longer have the log. so, well done, the title is now meaningless.

Comment 4 Quentin Retornaz 2020-07-21 11:35:43 UTC

Created attachment 650074 [details]
build.log

I tried to build this package as a dependency for another.
Here is my build.log.

Comment 5 Larry the Git Cow gentoo-dev

2020-08-14 23:23:37 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3bfdfabacefb21ca771607bc84b295389b4468cf

commit 3bfdfabacefb21ca771607bc84b295389b4468cf
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2020-08-02 22:11:07 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-08-14 23:23:32 +0000

    dev-ml/ocaml-gettext: ocaml-4.09 compat fixes
    
    Existing ebuild will not build with ocaml-4.09, only with older versions
    that have an outstanding GLSA (202007-48). ocaml-4.09 is being
    stabilized now.  This commit just uses the existing workaround/fix in
    b.g.o and updates the ebuild to EAPI=7.
    
    Updated to address feedback in https://github.com/gentoo/gentoo/pull/16964
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/731302
    Bug: https://bugs.gentoo.org/708696
    Package-Manager: Portage-3.0.0, Repoman-2.3.23
    Signed-off-by: Sam James <sam@gentoo.org>

 .../ocaml-gettext/files/ocaml-unsafe-string.patch  | 17 +++++++
 dev-ml/ocaml-gettext/ocaml-gettext-0.3.7-r1.ebuild | 59 ++++++++++++++++++++++
 2 files changed, 76 insertions(+)