Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 731268

Summary: dev-util/sysdig: incorrect --version built in
Product: Gentoo Linux Reporter: Holger Hoffstätte <holger>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH, PullRequest
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/24461
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Correctly set SYSDIG_VERSION during build

Description Holger Hoffstätte 2020-07-07 11:07:23 UTC
I just noticed something strange running sysdig-0.26.7:
$sysdig --version
sysdig version 0.1.1dev

As it turns out the CMake file does not set a proper version by itself and instead assumes that a build process sets the version appropriately, see
https://github.com/draios/sysdig/blob/dev/CMakeLists.txt#L45


Reproducible: Always

Steps to Reproduce:
1. emerge sysdig
2. run sysdig --version
3. observe built-in dummy version


Expected Results:  
The correct package version would be nice.
Comment 1 Holger Hoffstätte 2020-07-07 11:11:43 UTC
Created attachment 648232 [details, diff]
Correctly set SYSDIG_VERSION during build

Trivial fix to properly set the version during build. Version output is
now correct:

$sysdig --version
sysdig version 0.26.7
Comment 2 Larry the Git Cow gentoo-dev 2022-03-09 15:11:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff6f4895395998c1d0fbdbb53b4485b4e267973f

commit ff6f4895395998c1d0fbdbb53b4485b4e267973f
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2022-03-09 14:03:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-03-09 15:10:23 +0000

    dev-util/sysdig: set proper version information
    
    Closes: https://bugs.gentoo.org/731268
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/sysdig/sysdig-0.27.1-r100.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)