Bug 731116

Summary:	games-emulation/dolphin-5.0_p20200705: use BDEPEND with EAPI 7
Product:	Gentoo Linux	Reporter:	David Michael <fedora.dm0>
Component:	Current packages	Assignee:	Sergei Trofimovich (RETIRED) <slyfox>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	dolphin.patch

Description David Michael 2020-07-06 18:23:20 UTC

The package was just changed to EAPI 7 without defining BDEPEND.

  - At least pkgconfig should be in BDEPEND.

  - The gettext dependency looks for /usr/bin/msgmerge, and moving it to BDEPEND changes the number of cmake output commands from 771 to 799, so that appears to be its intended use.

  - The zip dependency does not seem to be used in DEPEND or BDEPEND since the archive was switched to tar.gz.

  - I'm not sure if the freetype dependency is needed.  It looks like it's used by the font-generating program under docs, but that appears to be only for reference and is not compiled.

Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev

2020-07-07 07:01:21 UTC

Can you attach a patch to the ebuild?

Comment 2 David Michael 2020-07-08 14:25:43 UTC

Created attachment 648376 [details, diff]
dolphin.patch

This is the change I was describing.

Comment 3 Larry the Git Cow gentoo-dev

2020-07-08 17:09:50 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=477ac5f25c88396e381d29335342157320eb606f

commit 477ac5f25c88396e381d29335342157320eb606f
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-07-08 17:09:26 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-07-08 17:09:45 +0000

    games-emulation/dolphin: use BDEPEND
    
    While at it drop unused dependencies.
    
    Fix-by: David Michael <fedora.dm0@gmail.com>
    Closes: https://bugs.gentoo.org/731116
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 games-emulation/dolphin/dolphin-5.0_p20200705.ebuild | 5 ++---
 games-emulation/dolphin/dolphin-9999.ebuild          | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev

2020-07-08 17:10:12 UTC

Applied. Thank you!