Bug 731024

Summary:	media-libs/libdc1394-2.2.6 fails to compile: control.c:286:19: error: fields must have a constant size: 'variable length array in structure' extension will never be supported
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo Media-video project <media-video>
Status:	CONFIRMED ---
Severity:	normal	CC:	2t2hmytc
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	408963
Attachments:	build.log other.tar.bz2 This patches solves the compiler errors ;-) [PATCH] Clang fix v2

Description Agostino Sarubbo gentoo-dev

2020-07-06 09:29:43 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/libdc1394 fails to compile.
Discovered on: amd64

NOTE:
This machine uses a clang/LLVM toolchain.
If you think that this issue is strictly related to clang/LLVM please block bug 408963. If you think that this issue isstrictly related to the LLD linker, please block bug 731004.

Comment 1 Agostino Sarubbo gentoo-dev

2020-07-06 09:29:48 UTC

Created attachment 647890 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2020-07-06 09:29:51 UTC

Created attachment 647892 [details]
other.tar.bz2

other logs

Comment 3 Agostino Sarubbo gentoo-dev

2022-01-11 07:30:59 UTC

tinderbox has reproduced this issue with version 2.2.6 - Updating summary.

Comment 4 Jan Koester 2023-05-24 13:19:27 UTC

Created attachment 862369 [details]
This patches solves the compiler errors ;-)

Comment 5 Maru 2024-02-07 23:18:00 UTC

Created attachment 884503 [details, diff]
[PATCH] Clang fix v2

I just tried the proposed patch and it's not working as intended, because it uses spaces as indentation everywhere, however in capture.c:324 (first change in the first hunk) the source file uses tabs instead. That's why the proposed patch fails to apply. Using two tabs for the source line corrects the issue and libdc1394-2.2.6 compiles successfully with clang!

I attached a revised patch file