Summary: | baselayout net module "ipppd" needs patch to work with isdn4k-utils-3.5_pre20041110 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Martin Wegner <gentoo-bugs> |
Component: | [OLD] baselayout | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | net-dialup, sbriesen, uberlord |
Priority: | High | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 66472 | ||
Attachments: |
The patch announced
ipppd module to fix stopping ipppd module to fix shutting down fixes clean_pidfile function |
Description
Martin Wegner
2004-12-01 13:04:51 UTC
Created attachment 45078 [details, diff]
The patch announced
This patch should work with all versions of isdn4k-utils
Forgot to add: for the issue with the test command the patch provides no solution since I do not know one ... net-dialup/isdn4k-utils fixed wuahhh, sorry, but /usr/sbin was the correct place. A symlink would be ok, but moving it into /sbin was silly. All other Distris install it into /usr/sbin. So not isdn4k-utils had to be fixed, but the baselayout. For the time being, a simple symlink would be the best solution! # ippdp.init script for the ebuild thinks ipppd should be in /sbin dodir /sbin mv ${D}/usr/sbin/ipppd ${D}/sbin/ipppd should be: # ippdp.init script for the ebuild thinks ipppd should be in /sbin dodir /sbin dosym /usr/sbin/ipppd /sbin/ipppd or just fixing the net.ippp0 script! I don't understand what base-system has to do with this bug. It is certainly a problem of ipppd.init script but this doesn't belong to baselayout, being a script installed by net-dialup/isdn4k-utils Fixed in the spirit of comment #4 (fixed path in net.ippp0 script). I believe Stefan is right; if pppd gets installed in /usr/sbin, why not ipppd do the same, especially because make install does that. comment #1: I don't have any idea from which script you took those lines. isdn4k-utils doesn't install a executable/script or script which contain the function called ipppd_stop. Also didn't saw "eend $? || return $?" anywhere. In comment #1 I referred to the file /lib/rcscripts/net.modules.d/ipppd introduced in baselayout-1.11.6 by uberlord@gentoo.org as requested by my bug #69035 . I wanted _one_ net script to do everything (as it is the sense of the new modules in the net scripts) and I did not want one net script for each type of interface (isdn, wlan, ...). So I guess the bug with the "test" issue reported also in comment #1 is not solved thus I'm reopening the bug. then it is indeed base-system's bug. I will add for the time being a symlink /sbin/ipppd @Alin: perfect! now I'm happy again! ;-) oh, before I forget it. please add a comment to the symlink thingy, that this is a temporary fix (refering to this bug #) and should be removed ASAP. oh, it's already in portage. doesn't matter. just add the comment and don't fix the version or let it be at all. I've fixed the location to /usr/sbin/ipppd in the net-scripts ipppd module Will be in baselayout-1.11.7 Fixed in baselayout-1.11.7-r1 ok, then we can remove the symlink in a few weeks. I'm working on some other enhancements for isdn4k-utils, so when they're ready, we can remove it then. but one question: if the functionality of net.ippp0 is included in net.lo now, then we don't need it (net.ippp0) anymore? Would be great! btw: is there any gentoo-wiki or such, where I can write a small doc/howto for Gentoo + ISDN/CAPI? net.ipppd will still be required until baselayout-1.11.x or better goes stable There's a wiki at http://gentoo-wiki.com/Main_Page - but it's not official afaik Bug with ipppd module ("test" issue in ipppd_stop in net module ipppd) I referred to in Comment #1 is still not fixed in baselayout-1.11.8: $ /etc/init.d/net.ippp0 stop * Stopping ippp0 * Bringing down ippp0 * Stopping ipppd for ippp0 [ !! ] * Shutting down ippp0 ... [ ok ] At shutdown I get: * Stopping ippp0 * Bringing down ippp0 * Stopping ipppd for ippp0 [ ok ] * Shutting down ippp0 ... [ ok ] I guess this happens because init already killed ipppd? So I still think that the error indicated by "!!" when stopping the interface manually is caused by the last test since you use $? as return value for eend huh, well. correct startup order: 1. /etc/init.d/capi (needed if you have a CAPI based card) /etc/init.d/hisax (needed if you have a hisax card) 2. /etc/init.d/isdn (needed for modem-emulation and ippp-devices) 3. /etc/init.d/net.ippp0 (needed only for non-CAPI cards. otherwise use pppd-capiplugin). stopping order reversed. but all components are optional! So you can't put "need" in depend(). "use" seems to start all optional components in the right order, but stops CAPI before ISDN, which is really odd. Changing "use" to "need" in depend() and everything works fine. But then all optional components are always started, no matter if I want this or not. :-/ What does the "Stopping ipppd" problem have to do with the starting order? nothing. but this is another issue we should take care of. Created attachment 48301 [details]
ipppd module to fix stopping
Please test this replacement ipppd module for stopping ipppd
Attached "ipppd" module works perfect for me Could you clarify that it starts, works, stops and no ipppd process is still running? And that it can start cleanly and work again? If you can answer yes to the above, I'll commit to CVS right away. Sorry for the hassle, but I have no way to actually test the ipppd module :/ I can confirm every point: it starts, works and stops. ipppd process is correctly started and stopped. It starts cleanly again. Commited to CVS - will be in baselayout-1.11.9 Sry, but I've just encountered an error that I could not encounter yesterday since I do not often shutdown my computer: When shutting down during the stopping an error message appears that starts with ERROR: List of process IDs must follow -p [...] The message is longer than this but I could not keep more. This does not appear when stopping the device manually. I cannot say which line exactly causes this. Created attachment 48386 [details]
ipppd module to fix shutting down
Created attachment 48387 [details, diff]
fixes clean_pidfile function
Please test with the new module and this patch to functions in
/lib/rcscripts/net.modules.d/helpers.d/functions
New ipppd module and patch work great for me in all of the above cases. Comitted to CVS - hopefully for the last time ;) Fixed by baselayout-1.11.9 |