Bug 730546

Summary:	sys-block/fio-3.20 : fails to build with -fno-common or gcc-10
Product:	Gentoo Linux	Reporter:	Toralf Förster <toralf>
Component:	Current packages	Assignee:	Robin Johnson <robbat2>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mlashley, prometheanfire
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=764152
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	705764
Attachments:	emerge-info.txt emerge-history.txt environment etc.portage.tbz2 logs.tbz2 sys-block:fio-3.20:20200703-065905.log temp.tbz2 Patch to fix -fno-common/gcc-10

Description Toralf Förster gentoo-dev

2020-07-03 09:53:15 UTC

/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: goptions.o:(.bss+0x0): multiple definition of `main_ui'; gfio.o:(.bss+0x20): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: gerror.o:(.bss+0x0): multiple definition of `main_ui'; gfio.o:(.bss+0x20): first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_developer-abi32+64-20200626-131934

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10.1.0 *
clang version 10.0.0 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/10/bin
/usr/lib/llvm/10
10.0.0
Available Python interpreters, in order of preference:
  [1]   python3.7
  [2]   python3.9 (fallback)
  [3]   python3.8 (fallback)
  [4]   python3.6 (fallback)
  [5]   python2.7 (fallback)
  [6]   pypy3 (fallback)
Available Ruby profiles:
  [1]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.41.1
  [2]   rust-1.44.1 *
The following VMs are available for generation-2:
*)	IcedTea JDK 3.16.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.0.2

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Fri 03 Jul 2020 06:05:25 AM UTC

emerge -qpvO sys-block/fio
[ebuild  N    ] sys-block/fio-3.20  USE="gtk zlib -aio -curl -glusterfs -gnuplot -io-uring -libressl -numa -python -rbd -rdma (-static) -tcmalloc -test -zbc" PYTHON_TARGETS="python3_7 -python3_6 -python3_8"

Comment 1 Toralf Förster gentoo-dev

2020-07-03 09:53:18 UTC

this seems to be either still an issue or a similarity to the one reported in bug 708546

Comment 2 Toralf Förster gentoo-dev

2020-07-03 09:53:20 UTC

Created attachment 647456 [details]
emerge-info.txt

Comment 3 Toralf Förster gentoo-dev

2020-07-03 09:53:23 UTC

Created attachment 647458 [details]
emerge-history.txt

Comment 4 Toralf Förster gentoo-dev

2020-07-03 09:53:26 UTC

Created attachment 647460 [details]
environment

Comment 5 Toralf Förster gentoo-dev

2020-07-03 09:53:28 UTC

Created attachment 647462 [details]
etc.portage.tbz2

Comment 6 Toralf Förster gentoo-dev

2020-07-03 09:53:31 UTC

Created attachment 647464 [details]
logs.tbz2

Comment 7 Toralf Förster gentoo-dev

2020-07-03 09:53:34 UTC

Created attachment 647466 [details]
sys-block:fio-3.20:20200703-065905.log

Comment 8 Toralf Förster gentoo-dev

2020-07-03 09:53:36 UTC

Created attachment 647468 [details]
temp.tbz2

Comment 9 Malcolm Lashley 2020-07-04 15:56:29 UTC

Created attachment 647582 [details, diff]
Patch to fix -fno-common/gcc-10

The following patch works for me.

Comment 10 Matthew Thode ( prometheanfire ) archtester

2020-07-04 18:45:13 UTC

I think we should stick to upstream

https://github.com/axboe/fio/commit/63a4b9cca4ba3aa4101051402cbbe946ced17a49

Comment 11 Larry the Git Cow gentoo-dev

2020-07-04 18:45:29 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=871c6d66637b79f8b3652c1c7ce897cfaa0775bb

commit 871c6d66637b79f8b3652c1c7ce897cfaa0775bb
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2020-07-04 18:45:14 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2020-07-04 18:45:14 +0000

    sys-block/fio: 3.20 fix gcc fno-common issue
    
    backported patch from upstream
    
    Closes: https://bugs.gentoo.org/730546
    Package-Manager: Portage-2.3.99, Repoman-2.3.23
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 sys-block/fio/files/fio-3.20-fno-common.patch |  51 +++++++++
 sys-block/fio/fio-3.20-r1.ebuild              | 157 ++++++++++++++++++++++++++
 2 files changed, 208 insertions(+)