Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 730190

Summary: Why does virtualx.eclass ignores dependency on xorg-server[xvfb] on prefix?
Product: Gentoo/Alt Reporter: Alexey <alexey+gentoo>
Component: Prefix SupportAssignee: Gentoo Prefix <prefix>
Status: RESOLVED FIXED    
Severity: normal Keywords: PullRequest
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/17941
Whiteboard:
Package list:
Runtime testing required: ---

Description Alexey 2020-06-29 22:38:49 UTC
Dependency on xvfb is declared like this: "!prefix? ( x11-base/xorg-server[xvfb] )"

This results in tests which rely on virtx to fail.
When I installed xorg-server[-elogind,xvfb] myself, and those tests succeeded.

What's the reason to disable that dependency on prefix?

Also I propose adding "xorg-server -elogind" to package.use of the prefix profile, because it's not very relevant there. I haven't tested xorg-server[elogind] though, maybe it would also work.
Comment 1 Larry the Git Cow gentoo-dev 2020-11-07 14:50:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a82b2524490da31ea9df557e0fcb200c401df02c

commit a82b2524490da31ea9df557e0fcb200c401df02c
Author:     Alexey Sokolov <sokolov@google.com>
AuthorDate: 2020-10-15 21:52:24 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2020-11-07 14:50:28 +0000

    virtualx.eclass: don't skip xvfb dependency on Prefix
    
    Closes: https://bugs.gentoo.org/730190
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 eclass/virtualx.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4586707c18a802093926ce6db7a9c3df075a9a73

commit 4586707c18a802093926ce6db7a9c3df075a9a73
Author:     Alexey Sokolov <sokolov@google.com>
AuthorDate: 2020-10-15 21:46:18 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2020-11-07 14:49:46 +0000

    profiles: prefix: mask USE=elogind in x11-base/xorg-server
    
    Bug: https://bugs.gentoo.org/730190
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 profiles/features/prefix/package.use.mask | 4 ++++
 1 file changed, 4 insertions(+)