| Summary: | libdv gtk dependency | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Markus Bertheau (RETIRED) <ska-fan> |
| Component: | New packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gentoo-bugs2, gnome, grandmasterlinux, kde, mholzer, mmihulya |
| Priority: | Lowest | ||
| Version: | 1.3 | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Configure patch to turn of gtk for compilation of lib and testprograms
Configure patch to turn of gtk for compilation of lib and testprograms Makefile.in companion for configure patch Modified ebuild Makefile diff for libdv-0.99 configure diff for libdv-0.99 diff to libdv-0.99 ebuild to fix gtkless compiling configure.ac autoconf patch (not directly needed for gentoo) fixed configure.diff for libdv-0.99 |
||
|
Description
Markus Bertheau (RETIRED)
2002-08-31 10:34:43 UTC
I have -gtk in my USE and no gtk+ version is installed. which version of libdv? libdv-0.98 The Problem is the following:
libdvs configure.ac checks for gtk even if --disable-gtk was passed. When I
patch configure.ac with that patch:
--- libdv-0.98/configure.ac Tue Jul 30 18:36:49 2002
+++ libdv-0.98-patched/configure.ac Sun Sep 15 15:32:09 2002
@@ -150,10 +150,12 @@
dnl Checks for libraries.
-REQUIRES='glib >= 1.2.4 gtk+ >= 1.2.4'
-PKG_CHECK_MODULES(GTK,$REQUIRES)
-dnl Libs above are required for the apps, but not for the lib itself.
-REQUIRES=''
+if $use_gtk; then
+ REQUIRES='glib >= 1.2.4 gtk+ >= 1.2.4'
+ PKG_CHECK_MODULES(GTK,$REQUIRES)
+ dnl Libs above are required for the apps, but not for the lib itself.
+ REQUIRES=''
+fi
dnl pass-thru to .pc files
AC_SUBST(REQUIRES)
, a compile with gtk in USE succeeds, without gtk, it fails:
checking for XvQueryAdaptors in -lXv... no
configure: error: Could not find Xv Lib
!!! ERROR: The ebuild did not complete successfully.
I have no idea.
The following patch, unrelated, can be applied to the ebuild:
--- libdv-0.98-r1.ebuild Sun Sep 15 15:51:41 2002
+++ /usr/portage/media-libs/libdv/libdv-0.98.ebuild Wed Aug 14 15:20:44 2002
@@ -15,11 +15,9 @@
DEPEND=" dev-libs/popt
gtk? ( =x11-libs/gtk+-1.2* )
gtk? ( =dev-libs/glib-1.2* )
- x11-base/xfree
+ xv? ( x11-base/xfree )
dev-util/pkgconfig
sdl? ( >=media-libs/libsdl-1.2.4.20020601 )"
-# If we comment out the conditional xv-disabling below, make that dep
non-optional, too
-# xv? ( x11-base/xfree )
src_compile() {
Can you maybe make a working patch ? I doubt the config.ac file is actually used .. I would appreciate it, i won't have time to have a good look at this myself for some time and it's not really a gtk issue, more like a broken config script. reopening Your bug, you can fix it or close it or whatever you like ;) I don't think the gnome team will get around to it any time soon (or any time ever to be more realistic :/). is this still an issue ? It seems to be. I just now emerge rsynced, then tried to emerge libdv with - gtk in USE, and no gtk installed. I got errors exactly as in the original bug report. I can confirm Jim Marshall, this is still an issue. I encountered this while trying to emerge mplayer, and after checking the mplayer ebuild i constated that if you want mplayer with mencoder (encode use flag), it needs libdv (wich is not very logical to me, afaik mencoder works perfect without libdv). I never intend to use the DV format, so this is a bit annoying. I have the same problem, i have USE="-gtk" (i dont have GTK+ 1.2 installed) and emerging libdv fails. Created attachment 11563 [details, diff]
Configure patch to turn of gtk for compilation of lib and testprograms
This patch improves the handling of --disable-gtk and --disable-gtktest (make
them actually work) so you can compile libdv without gtk.
Created attachment 11564 [details, diff]
Configure patch to turn of gtk for compilation of lib and testprograms
This patch improves the handling of --disable-gtk and --disable-gtktest (make
them actually work) so you can compile libdv without gtk.
Created attachment 11565 [details, diff]
Makefile.in companion for configure patch
Needed by the configure patch to disable gtktest software compile
Created attachment 11566 [details]
Modified ebuild
Modified ebuild to also disable gtk test software. (Warning enables xv-config)
Thanks very much for this patch, I'll try to get it in soon. Have you tried to get them upstream, i.e. to the libdv devs? Please, please, please... Can you pass it to the main portage tree as soon as possible, please? My whole cluster is useless until then... :-( Radek Podgorny Created attachment 11885 [details, diff]
Makefile diff for libdv-0.99
Created attachment 11886 [details, diff]
configure diff for libdv-0.99
Created attachment 11888 [details, diff]
diff to libdv-0.99 ebuild to fix gtkless compiling
Comment on attachment 11886 [details, diff]
configure diff for libdv-0.99
will try to create an autoconf/automake-patch as well and push it to libdv
developers
Created attachment 11900 [details, diff]
configure.ac autoconf patch (not directly needed for gentoo)
I will try to push this patch for configure.ac to libdv-developers to fix this
problem once and for all.
Hmm, your configure patch doesn't quite work here: amethyst libdv # USE="-gtk -sdl -xv" emerge libdv Calculating dependencies ...done! >>> emerge (1 of 1) media-libs/libdv-0.99-r1 to / >>> md5 ;-) libdv-0.99.tar.gz >>> Unpacking source... >>> Unpacking libdv-0.99.tar.gz to /var/tmp/portage/libdv-0.99-r1/work patching file Makefile.in patching file configure Reversed (or previously applied) patch detected! Assume -R? [n] y >>> Source unpacked. configure: WARNING: If you wanted to set the --build type, don't use --host. If a cross compiler is detected then cross compile mode will be used. checking build system type... i686-pc-linux-gnu checking host system type... i586-pc-linux-gnu checking target system type... i586-pc-linux-gnu [...] checking for pkg-config... /usr/bin/pkg-config checking for glib >= 1.2.4 gtk+ >= 1.2.4... sh: line 1: gtk-config: command not found sh: line 1: gtk-config: command not found sh: line 1: gtk-config: command not found sh: line 1: gtk-config: command not found sh: line 1: gtk-config: command not found sh: line 1: gtk-config: command not found Requested 'gtk+ >= 1.2.4' but version of GTK+ is configure: error: Library requirements (glib >= 1.2.4 gtk+ >= 1.2.4) not met; co nsider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them. !!! ERROR: media-libs/libdv-0.99-r1 failed. Created attachment 12188 [details, diff]
fixed configure.diff for libdv-0.99
There is a bug in libdv-0.99.ebuild
xv-line contains cong instead of conf
Thanks! I applied the patches from attachement 11885 attachement 11888 attachement 12188 and libdv-0.99 compiled fine for me without requiring gtk+-1.2. Just want to remind that this bug is still an issue! This bug makes it hard to keep the box GTK 1 free. libdv ist depended on by many packages! gtk guru :) not this one again thanks to christian for the patches. i've put in a libdv-0.99-r1 with gtk+ disabling working. i note that max@gentoo.org had just removed the gtk useflag from libdv-0.99. I don't know is it a sequence from this bug, or a new bug. But there is next problem with libdv-0.99-r1: if I try to ACCEPT_KEYWORDS=~x86 USE="-gtk" emerge libdv then error occurs on 'configure' stage: """ checking for XvQueryAdaptors in -lXv... no configure: error: Could not find Xv Lib !!! ERROR: media-libs/libdv-0.99-r1 failed. !!! Function econf, Line 320, Exitcode 1 !!! econf failed """ But if I try ACCEPT_KEYWORDS=~x86 USE="gtk" emerge libdv then configure stage accomplishes successfully. (xv-3.10a-r3 is installed) """ checking for gtk-config... /usr/bin/gtk-config checking for GTK - version >= 1.2.4... yes checking for XvQueryAdaptors in -lXv... yes """ If this another bug, please open new bug, elsewhere reopen this bug. with last patch all works fine thanks for great job! |